Coder Social home page Coder Social logo

Add a webhook for builds about poggit HOT 13 OPEN

poggit avatar poggit commented on June 4, 2024 4
Add a webhook for builds

from poggit.

Comments (13)

SOF3 avatar SOF3 commented on June 4, 2024 6

Webhooks might be a better choice after all.

from poggit.

SOF3 avatar SOF3 commented on June 4, 2024 2

Webhooks will be implemented in a way similar to that in Travis-CI. Available actions should include "email", "slack", "gh-comment", "webhook" and "notifico".
I don't want to play with crypto stuff, so there may be an internal key storage uploaded to Poggit directly.

from poggit.

SOF3 avatar SOF3 commented on June 4, 2024 1

What do you think if we only send commit comments to the repo (see #31) and then you detect the information according to the commit comments? This is still possible, as a commit comment is sent by @poggit-bot if and only if it is a comment related to reviewing. We may have some <!-- {"json":["data","here"]} --> in the comment.

from poggit.

SOF3 avatar SOF3 commented on June 4, 2024

Any specific information you need in such a webhook?

from poggit.

Thunder33345 avatar Thunder33345 commented on June 4, 2024

I would guess just general like centralized overview of things on x channel

from poggit.

catgirlinspace avatar catgirlinspace commented on June 4, 2024

Build status (Failed, 1 lint error, Passed) and if it failed or had a lint error it should probley include why it failed. It should also include a link to the build, the repo name, and the build number (dev:1, pr:1). Of course, there's a lot more, but this is all I can think of.

from poggit.

catgirlinspace avatar catgirlinspace commented on June 4, 2024

And for things like releases getting reviewed, it should include the GitHub name of the reviewer, the review, and what release the review was posted on.

from poggit.

catgirlinspace avatar catgirlinspace commented on June 4, 2024

That might work, but I still think proper webhooks should be added.

from poggit.

SOF3 avatar SOF3 commented on June 4, 2024

Proper webhooks will require an additional interface for webhook management, which requires much work. I don't want to unnecessarily reinvent something that we can access already.

from poggit.

Thunder33345 avatar Thunder33345 commented on June 4, 2024

i would recon just scrap poggit in a gentle way
by whenever a commit is made, send a POST to a handler which would figure out build ID and so on,
then proceed to scrap poggit for lint issues
then calling the discord webhook, IF there any issues

from poggit.

SOF3 avatar SOF3 commented on June 4, 2024

Webhook management and the relevant security management etc. would indeed be a lot of work. I will keep it to GitHub comments.
Also note that there is supposedly a "user timeline" feature, which is a list API for the user's latest notifications, but not webhooks.

from poggit.

SOF3 avatar SOF3 commented on June 4, 2024

Duplicates #31.

from poggit.

catgirlinspace avatar catgirlinspace commented on June 4, 2024

Yay!

from poggit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.