Comments (13)
Webhooks might be a better choice after all.
from poggit.
Webhooks will be implemented in a way similar to that in Travis-CI. Available actions should include "email", "slack", "gh-comment", "webhook" and "notifico".
I don't want to play with crypto stuff, so there may be an internal key storage uploaded to Poggit directly.
from poggit.
What do you think if we only send commit comments to the repo (see #31) and then you detect the information according to the commit comments? This is still possible, as a commit comment is sent by @poggit-bot if and only if it is a comment related to reviewing. We may have some <!-- {"json":["data","here"]} -->
in the comment.
from poggit.
Any specific information you need in such a webhook?
from poggit.
I would guess just general like centralized overview of things on x channel
from poggit.
Build status (Failed, 1 lint error, Passed) and if it failed or had a lint error it should probley include why it failed. It should also include a link to the build, the repo name, and the build number (dev:1, pr:1). Of course, there's a lot more, but this is all I can think of.
from poggit.
And for things like releases getting reviewed, it should include the GitHub name of the reviewer, the review, and what release the review was posted on.
from poggit.
That might work, but I still think proper webhooks should be added.
from poggit.
Proper webhooks will require an additional interface for webhook management, which requires much work. I don't want to unnecessarily reinvent something that we can access already.
from poggit.
i would recon just scrap poggit in a gentle way
by whenever a commit is made, send a POST to a handler which would figure out build ID and so on,
then proceed to scrap poggit for lint issues
then calling the discord webhook, IF there any issues
from poggit.
Webhook management and the relevant security management etc. would indeed be a lot of work. I will keep it to GitHub comments.
Also note that there is supposedly a "user timeline" feature, which is a list API for the user's latest notifications, but not webhooks.
from poggit.
Duplicates #31.
from poggit.
Yay!
from poggit.
Related Issues (20)
- "poggit build" in commit message may lead to 500ISE HOT 4
- Be more consistent with github button placements HOT 4
- Display plugin code size or update diff size in review queue HOT 2
- "Release Search" Problem HOT 1
- Problem with query bar HOT 2
- Argo Tunner Error HOT 3
- Poggit down: Argo tunnel error HOT 1
- Add an api getter for latest dev builds without providing a commit hash or resource id input HOT 11
- jquery.com having a bad day, all requests taking forever HOT 3
- Blank Plugin Release List HOT 7
- src-namespace-prefix in PHPStan and lint HOT 5
- Frozen - Lint doesn't support PHP 8.1 HOT 17
- Extract Virion Injector HOT 7
- Support for duplicate plugin names HOT 3
- Release List API - flag problem
- RFC - Overwriting plugin manifest details on release HOT 2
- Virion incompatibility with PSR-4
- Missing Access-Control-Allow-Origin (CORS) Header HOT 2
- Poggit returns 403 if plugin name in search contains space
- Blank plugin search HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poggit.