Brushes - Adding/Fixing/Upgrading! about mcedit-unified

[Rubisk]

mcedit/mcedit#365 got some work done on this. Wanted to make an ALT+G and ALT+E key to rotate blocks seperately, but apparently mcedit doesn't support key combinations yet. sigh

I'll instead just add an option in the menu to rotate blocks with the brush. If you want to just rotate the block, I guess you'll have to reselect the block T__T

[Rubisk]

Added option to rotate blocks with brush, see pull request .

You can't rotate blocks individually yet, don't know what keys to bind it too.
Also, apparently it's impossible to rotate a paste selection, working on that next I guess.
And, apparently the key that you bind to "mirror" mirrors indeed the clone tool, but also works as roll key for the brush. In the brush tool, pressing the roll key does nothing. Might want to fix that?

[TrazLander]

@Skinny121 in this 4d6ce48 commit made it so clone and schematics now work for all blocks and not the schematic itself using Alt plus the rotate/roll/flip/mirror key (Alt+e,Alt+r,Alt+f,Alt+g). It should be added this way for these brush options too.

[Rubisk]

Brush Presets have been succesfully added in the master branch.
Alt+E/G/R/F doesn't work, not on clone tool either.

[TrazLander]

Closing this as it's mostly complete in its current state and not currently active. Can reopen or just keep it closed and still use this for any ongoing discussion for improving brushes in the future!

[Khroki]

Reopening for the moment as I'm getting this if I use wireframe at the chunk border with W and L set to 17. Also that button needs some work.

[Khroki]

Also right after starting mcedit, clicking any of the presets always activates 1, works fine after that.

[Rubisk]

I fixed the brush preset always loading 1 the first time, don't know what is causing those weird borders though, like really don't. Will look into it ASAP.

[Khroki]

Problems fixed, thanks.

[TrazLander]

I fixed the brush preset always loading 1 the first time

Looks like you fixed it by making it select nothing at all. When you first load mcedit, there are no brushes selected:

This creates a weird situation where you have a NULL brush that can only be accessed the first time you select the brush tool after opening mcedit.
I think it should select "1" by default for new users of the program, and you should have it save last used brush and keep it selected even after you’ve closed and re-opened the program. If all that is possible...

Or another way to go about it is truely have a NULL brush that doesn't get saved. Something like having all the brushes
1 2 3 4 5 6 7 8 9 X
Where X would deselect any saved brushes, and this would be the default state that would be selected when first open the brush tool, which is exactly what it currently does. So it'd just be a way to integrate what's currently happening.

[Rubisk]

Reworked presets a6a918c

[TrazLander]

did you mean to link the commit with that comment :P

[Rubisk]

What are you talking about? :D

[Rubisk]

Fixed tons of bugs and added remove option 32cbdf0

[Rubisk]

Next up is custom imported brush classes. Before I do that, I need to completetely revamp the setup of brushes. At the moment, it's really messy. Options are all over the place, called in 20 different ways, some using properties, some dictonaries, some just general 'static defs'(?). It's a mess, and needs to be cleaned up. I will try export all current brushes to files as well, makes for more consistent code, and just put those in your brushes folder? Or keep them somewhere in a standard folder?

[Podshot]

@Rubisk I can help you with the custom brushes if you would like

[TrazLander]

Closing this since it's mostly inactive now and main stuff is implemented.