Comments (5)
@Magellol @JeremyRH immer can't (and won't) allow async state, but the store can still be transformed towards immer using middleware. The overhead of set remains, but at least it can mutate, and these sets then can then be async. See: https://codesandbox.io/s/5k77o8lzkn
export const immer = config => (set, get) => config(fn => set(produce(fn)), get)
const [useStore] = create(immer(set => ({
count: 1,
inc: async () => {
await delay(2000)
set(state => void state.count++)
},
dec: () => set(state => void state.count--)
})))
The twitter discussion where this came up: https://twitter.com/0xca0a/status/1116390665607421952
from zustand.
Hi, thanks for the feedback!
So the problem is the immer draft is stale by the time you mutate it. Even if zustand resolved promises in set
, it wouldn't fix the issue because the resolved value would be stale state.
The only way I can think of solving the issue is to await the async values before calling set
:
import produce from "immer";
import create from "zustand";
const fetchThing = () => Promise.resolve("thing");
const [, api] = create((set, get) => {
const setState = fn => set(produce(get(), fn));
return {
things: [],
async addThing() {
setState(draft => {
draft.things.push("first thing");
});
const asyncThing = await fetchThing();
setState(draft => {
draft.things.push(asyncThing);
});
}
};
});
api.subscribe(console.log);
api.getState().addThing();
from zustand.
Sure it's the same thing essentially.
from zustand.
Thanks for the replies :)
@drcmda Just so I understand, are you saying that the method proposed by @JeremyRH right above wouldn't work either? I've tried both in codesandbox and it seems I can yield the same results (yours and Jeremy's solution). https://codesandbox.io/s/v6qno7xznl
from zustand.
Thanks for clarifying. I think we can close this issue then.
from zustand.
Related Issues (20)
- Is there a way to reset data when switching routes? The previous method cannot take effect#1192
- Type problem with persist HOT 3
- Reset store not working on log out
- I can't update state with new data from Tanstack Query HOT 2
- The app hanging when initializing the store with and array of objects. HOT 4
- Is there any chance to simplify types?
- How to move the router state to store?
- Website graphics rendering issues (Linux) HOT 3
- shallow not support nested object HOT 1
- Are these two methods exactly the same? HOT 1
- Itβs not recommended to suspend a render based on a store value returned by useSyncExternalStore.
- RFC: How is v5-alpha? HOT 11
- should useShallow add into the documents?
- Can't use persist with context implementation mentioned in the docs for Next.js HOT 1
- Re-render issue while performing open and setOpen using shadcn
- Re-render issue while performing open and setOpen using shadcn HOT 1
- type WithoutCallSignature<T>
- docs: Add suggestions about getInitialState on persist
- Cant user Array of Map type to store data
- overview of the zustand API HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zustand.