Coder Social home page Coder Social logo

Comments (5)

krispya avatar krispya commented on June 18, 2024 7

So just to follow up, you can fix this issue yourself by setting the frameBufferType prop on EffectComposer to HalfFloatType which you import from three.

from react-postprocessing.

Russo-creation avatar Russo-creation commented on June 18, 2024 2

Thank you @Krispy3000 your solution works perfectly. I wasn't aware of this change between versions.
Below code which solves colors issue.

        import * as THREE from "three";
        import {
          EffectComposer,
          Bloom,
        } from "@react-three/postprocessing";
.
.
.
      <EffectComposer frameBufferType={THREE.HalfFloatType}>
        <Bloom
          luminanceThreshold={0}
          luminanceSmoothing={0.9}
          height={300}
          opacity={3}
        />
      </EffectComposer>

from react-postprocessing.

Russo-creation avatar Russo-creation commented on June 18, 2024

+1

Recently I noticed the same issue. I tried experiment with different light source like point light and environment HDRI and same behavior as you describe.

I checked if it is coused by some specyfic post-processing effect but same regardless of used effect. It looks like there is issue related with EffectComposer component itself.

I checked the demo from https://vanruesc.github.io/postprocessing/public/demo/#bloom and didn't noticed this issue.

  • with post-processing | without post-processing
    effectcomposer

Edit

I also made an additional investigation for this issue and discoverd that colors in example demo https://codesandbox.io/s/pqrpl also suffer for mentioned effect (especially visible on bloom glow). I tried to find some older example to check if something happpend in the past https://codesandbox.io/s/vigorous-currying-3r6l2 and I noticed that older version of this library1.4.0 doesn't have this issue.

  • newest ver of lib | library1.4.0

demos

from react-postprocessing.

Russo-creation avatar Russo-creation commented on June 18, 2024

@react-three/post processing ver 2.0.0 colors are also grate. Issue is noticeable in versions 2.0.1 and above!

from react-postprocessing.

krispya avatar krispya commented on June 18, 2024

I was reimplementing the postprocessing library myself to see what might be the problem and I was able to reproduce this issue by not setting the render frameBufferType to HalfFloatType. If it does get set, the color banding goes away. You can see the issue yourself in this sandbox by commenting out the two renderer options:

https://codesandbox.io/s/blissful-hamilton-zi963?file=/src/App.js:1433-1527

from react-postprocessing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.