Comments (5)
unphased
commented on June 16, 2024
1
Sure, thanks for the invite! You think we should just add it as a boolean prop that defaults to the current behavior? I'll call it disableNormalPass? I will try to add a check if SSAO is used to make it fail with a friendly error message.
from react-postprocessing.
gsimone
commented on June 16, 2024
Could you open a PR to add a flag to the effectComposer component to turn normal on/off?
from react-postprocessing.
gsimone
commented on June 16, 2024
If you need help, let's talk on the react-three--postprocessing channel on the pmndrs discord https://discord.gg/xSKQjggpeU
from react-postprocessing.
gsimone
commented on June 16, 2024
Yeah, that would be the safest bet and it would just be a minor release. We should keep in mind an eventual API change for a future major ✌️
from react-postprocessing.
unphased
commented on June 16, 2024
Closing because #66 is merged, thanks.
from react-postprocessing.
Related Issues (20)
- SSR not working in Nextjs 13 (Reproduction in description) HOT 2
- Outline not showing for 2.9.0 and above HOT 2
- N8AO Named export 'Pass' not found HOT 11
- Selection/Select Clipping Plane Compatibility
- Issue with "object traces" when using SSR HOT 1
- react-native support? HOT 2
- Performance-bug with `<Select />`
- The library is not tree-shakable due to SSAO HOT 1
- setSize always get overwritten by the unrounded parent DOM size. HOT 1
- Bloom Filter breaking Scene in Chrome - Cannot read properties of null (reading 'alpha') HOT 1
- Hello，How to display different colors?
- EffectComposer and Typescript
- Next 13+ EffectComposer Import Error HOT 3
- Added the Custom Effect of Sharpeness
- Live demo broken
- Remove yarn, just adds complexity
- "no exported member" errors when using NodeNext module/moduleResolution in TypeScript
- Selection causes endless loop
- DepthOfField issue: white halo around objects when using resolutionScale < 0.5
- Upgrade `postprocessing` dependency to latest HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-postprocessing.