BaseInventory::contains() does not work with custom item names about pocketmine-mp

[legoboy0215]

Because of this, I had to resort to other methods like iterating through the player's inventory.

[SOF3]

Why would you run break; after a return true; statement 😕 it is dead code.

[Intyre]

It works fine for me.

Run ci first to clean the inventory and then ic twice. First time it will add the items and second time it doesn't because the inventory contains the items.

https://github.com/pmmp/PocketMine-MP/blob/0.16/src/pocketmine/item/Item.php#L548
https://github.com/pmmp/PocketMine-MP/blob/0.16/src/pocketmine/inventory/BaseInventory.php#L162
$checkTags = $item->getCompoundTag() === null ? false : true;

public function onCommand(CommandSender $sender, Command $command, $label, array $args){
    if(!($sender instanceof Player)){
       $this->getLogger()->info("Not a Player!");
       return true;
    }
    switch($command->getName()){
        case "ic":
           $item = Item::get(Item::STONE, 0, 1);
           if(!$sender->getInventory()->contains($item)){
               $this->getLogger()->info("Item not found");
               $sender->getInventory()->addItem(clone $item);
           }

           $item->setCustomName("Not stone");
           if(!$sender->getInventory()->contains($item)){
               $this->getLogger()->info("Item with custom name not found");
               $sender->getInventory()->addItem(clone $item);
           }
           return true;
        case "ci":
           $sender->getInventory()->clearAll();
           return true;
        default:
           return false;
    }
}

[Sandertv]

Hmmm I must have done something wrong then...