Comments (3)
Hi @LegendPhoenix66, thanks for reporting this.
The Java language has 4 solutions defined. Which of those does the issue concern?
from primes.
looks like I somehow got an old version where there was only one Java solution. I just tested it in the current versions. With sieveSize 10 in the 3rd Solution it's still the case. I also found a problem in solution 2 where printf has %d but the argument is String.valueOf(num). And I would maybe replace \n with %n in String formats
from primes.
I see that PrimeJava/solution_3 indeed performs a "less than" (<) comparison to the square root of the sieve size, instead of a "less than or equal to" (<=) comparison.
However, as none of the points you mention impact the solutions' accuracy or performance in the context of the actual drag race (where the sieve size is 1,000,000), they do not represent an issue in the context of this repo. You can open (a) PR(s) to propose the changes you suggest to the solutions they concern, if you want to do so. Otherwise, I will convert this issue to an improvement suggestion discussion. I'd like to note that the chances of the solutions' contributors responding to your findings will increase if you tag them in your post.
from primes.
Related Issues (20)
- Handling Legal Questions re: Dyalog APL HOT 8
- PrimesV/solution_2 does not build HOT 1
- Bad access on CPP Solution3 with clang (macOS ARM64) HOT 3
- Number of threads isn't being reported by awk solution 1 HOT 4
- primeJava/solution_4 showing about 10 seconds of run time on core2 duo HOT 4
- Dart/solution_1 hangs on 5950X runner HOT 5
- need a command to compile without running
- All Benchmarks Fail to Compile HOT 9
- I have a coldfusion solution
- Rust solution 1 takes 10 seconds instead of just 5 HOT 1
- would have been nice to include a list of the results for those who don't have the time to set this up. HOT 1
- Ruby solution takes > 4 hours to complete. HOT 9
- Question: Is inline assembly allowed?
- Thoughts on Prime Number Generation Challenge and a Possible Spin-Off HOT 1
- Request: more esoteric languages
- Odin/solution_1 doesn't compile with the current (dev-2024-02) version of Odin HOT 2
- OCaml solutions don't build with current version of OCaml HOT 2
- Pascal Parameters can use const word to be fastest HOT 1
- Benchmark Rules violation — not using bit per number? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primes.