Add an additional link tag with hreflang x-default to improve locale detection fallback about strapi-plugin-sitemap

[boazpoolman]

Yep that sounds like a plan.

So that would be an extra select input (dropdown) in this section:

And the values of that select input can be:

• Disabled
• Default language pathname
• Other

And when somebody selects the Other option an extra text input field should show in which the user can put the path of their choice.

And yeah just have disabled be the default makes sense. That would make this backwards compatible as well.

@RomainGueffier Do you want to make this contribution?

[boazpoolman]

Hi @RomainGueffier

Thanks for submitting this feature request!
I think this can be a great addition to the plugin.

I'm wondering how much control the user needs for this value.
You're suggesting to have the hreflang="x-default" be the value from default locale pathname.
Though in the article I also read you might want to set it to be a language selection page.
Do you think this should be set globally (like the hostname), or should you be able to change the hreflang="x-default" per URL bundle?

[RomainGueffier]

Glad you like the idea 🚀 ! I don't need the use case with a specific neutral page having language selector, but it should be done for sure.

I'm not sure how to make good UI/UX. As global option seems good to choose between:

• disabled (default?)
• a specific path
• generate from default language pathname on every internationalised url bundles

No need for per-bundle settings if so.

What do you think?

[RomainGueffier]

@boazpoolman deal! I will create PR soon. Do you have any default .vscode/settings.json or prettier config?

[boazpoolman]

The repo has eslint configured for all linting and code formatting.
If you install the eslint plugin in vscode you should get highlighting on warning & errors :)