Comments (2)
I think it's because when we addded Link
, we only had the Python API (not the pipeline.yaml API), and we never worked on ensuring it'd work with pipeline.yaml
. Feel free to open a PR!
from ploomber.
@edublancas I will. I could use a little guidance from you, though.
Locally, I've got this signature for Link:
class Link(Task):
...
def __init__(self, source, product, dag, name=None):
kwargs = dict(hot_reload=dag._params.hot_reload)
self._source = type(self)._init_source(kwargs)
super().__init__(product, dag, name, None)
And tasks using Link tend to look like:
# Dummy task to wrap success stories exported from hubspot
- name: success-stories
source: ""
product: "{{PRODUCTS_DIR}}/success-stories.csv"
class: Link
product_class: File
Which, isn't terrible but the blank source
, the class
, and the product_class
could all be a little confusing.
I don't think I can get around the source
issue without quite a bit of rewiring in the spec task validation (which strictly looks for source
without OO/protocol based validation). The product_class issue may be solvable by trying to validate whether product is a pathlike or url-like.
I suppose I could make any string that matches source.lower() == "link"
get a class
of Link. Maybe that kills two birds with one stone?
Let me know your thoughts.
from ploomber.
Related Issues (20)
- deprecate `ploomber cloud`
- remove `ploomber cloud` HOT 2
- delete integration tests
- fix binder github action
- Python API compatibility with custom Papermill engines HOT 3
- How to disable warning? HOT 2
- add support for jupyter notebook 7 HOT 5
- remove autopep8 dependency
- pinned pycodestyle HOT 2
- add option to hide all progress bars HOT 1
- Rendering Glitch in DAG Plot Generated by `ploomber plot` HOT 2
- broken CI due to telemetry changes HOT 1
- documentation is broken
- `jupyter_server` 2.11.0 introduces breaking change to `contents_manager.get`
- CI is broken
- Allow user defined product and task classes HOT 1
- The 2023 JupyterCon video is not on the Videos page HOT 2
- docs failing
- pinned sphinx version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ploomber.