Comments (5)
I see that we now have github actions in many Plone repositories. Should we add this in https://github.com/plone/meta?
CC @gforcada
from plone.restapi.
@Akshat2Jain would you like to do a PR to fix this? It's basically putting pull_request
in on
in all .yml
files here:
https://github.com/plone/plone.restapi/tree/master/.github/workflows
It is also necessary to put:
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
in all jobs. See:
from plone.restapi.
@Akshat2Jain would you like to do a PR to fix this? It's basically putting
pull_request
inon
in all.yml
files here:https://github.com/plone/plone.restapi/tree/master/.github/workflows
It is also necessary to put:
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
in all jobs. See:
Yeah Sure!
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
So basically the above code states that this condition ensures that the job is only executed when the event is not a pull request or when the head repository (fork) is different from the base repository.
right? @wesleybl
from plone.restapi.
@Akshat2Jain exactly! This prevents jobs from running twice if it's a PR made from the original repository.
from plone.restapi.
@wesleybl yes, contributions to plone/meta
are always welcome, though plone.rest
and plone.restapi
are still not converted/adjusted to use plone/meta
.
@tisto wanted to discuss that during the Bonn sprint, but did not happen 😅 but yeah, in a way or another it will be configured eventually, so contributions there to improve its quality and usability would be great 👍🏾
from plone.restapi.
Related Issues (20)
- Add Spanish translation HOT 1
- CI Badge HOT 2
- Github Actions are skipped HOT 3
- Undeprecate comma separated expansion parameters HOT 8
- Undeprecate token parameter from vocabularies endpoint HOT 9
- Code that seems to do nothing HOT 2
- Drop Python 3.7 support HOT 1
- jwt_auth PAS plugin is active without being installed HOT 9
- Global Site tabs should also be customizable with customize_entry HOT 5
- navigation_base_url is not also used here HOT 2
- json_body should not read entire request BODY HOT 5
- debug-exceptions = on in instance part in buildout causes requests that return BadRequest to be returned as html instead of json
- KeyError: 'portal' in tests with Python 3.12.1 HOT 10
- Translate validation error messages
- IBlocks SearchableText indexer bypasses plone.textindexer behavior HOT 2
- relatedItems field returns None in the serializer if the related item is deleted HOT 1
- Site Administrator cannot add user to group
- Add remote_url(getRemoteUrl) to link content-types in navigation HOT 4
- Include release notes in Plone 6 Documentation
- Authentication error messages from PAS Plugins aren't returned by the restapi HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plone.restapi.