Coder Social home page Coder Social logo

Log Removal warning on Folia about coreprotect HOT 4 OPEN

ewof avatar ewof commented on July 29, 2024 1
Log Removal warning on Folia

from coreprotect.

Comments (4)

Intelli avatar Intelli commented on July 29, 2024

The issue is that SmoothTimber is passing data into an async thread that isn't safe for Folia.

I.e. the issue here is that SmoothTimber doesn't fully support Folia.

from coreprotect.

Lauriichan avatar Lauriichan commented on July 29, 2024

SmoothTimber is working with already read data (BlockStates) while the CoreProtectAPI does not.
In my opinion it's not our issue to call your api in a thread that is suited for your access to data in the world.
You are the one trying to access the world data in your api instead of exposing a method that allows other developers to skip this step, this is unnecessary.

from coreprotect.

Lauriichan avatar Lauriichan commented on July 29, 2024

We're not just supporting CoreProtect in our plugin however so far the CoreProtectAPI was the only thing that caused issues when being used on Folia. So I would say this is just bad api design meaning the one that does not fully support Folia is not SmoothTimber but CoreProtect instead as the API does not comply with folia standards.
You will see that your API is accessing the world (in the stack trace) and not SmoothTimber.

from coreprotect.

Lauriichan avatar Lauriichan commented on July 29, 2024

Also please note that I'm not trying to attack anyone here and I apologize if any of the above sounds rude in any way

from coreprotect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.