Comments (4)
The issue is that SmoothTimber is passing data into an async thread that isn't safe for Folia.
I.e. the issue here is that SmoothTimber doesn't fully support Folia.
from coreprotect.
SmoothTimber is working with already read data (BlockStates) while the CoreProtectAPI does not.
In my opinion it's not our issue to call your api in a thread that is suited for your access to data in the world.
You are the one trying to access the world data in your api instead of exposing a method that allows other developers to skip this step, this is unnecessary.
from coreprotect.
We're not just supporting CoreProtect in our plugin however so far the CoreProtectAPI was the only thing that caused issues when being used on Folia. So I would say this is just bad api design meaning the one that does not fully support Folia is not SmoothTimber but CoreProtect instead as the API does not comply with folia standards.
You will see that your API is accessing the world (in the stack trace) and not SmoothTimber.
from coreprotect.
Also please note that I'm not trying to attack anyone here and I apologize if any of the above sounds rude in any way
from coreprotect.
Related Issues (20)
- Crash randomly HOT 3
- [Suggestion] Logging of /execute commands HOT 4
- NPE on v22.4 HOT 10
- Could not pass event InventoryMoveItemEvent to CoreProtect HOT 8
- I don't know, I don't know how to fix this serious bug in
- enum constant HORSE_JUMP_STRENGTH does not exist in class org.bukkit.attribute.Attribute
- Bug wind 1.20.6 HOT 1
- CoreProtect using MySQL can not properly use the/Co purge command to clean up old/useless data. HOT 12
- Killing mob using Mace enchanted with Wind Burst creates fake #explosion logs
- Spam In Logs When Breaking A Block HOT 1
- Console spam on PlayerDeathEvent HOT 1
- /co rollback cant rollback command like /fill or how to use /co rollback action: command HOT 1
- Rollback does not work when inventory is full HOT 1
- Update to 1.21
- Add Decorated Pot log HOT 1
- The console spams the problem and the ping is rising. magma core version 1.20.1 HOT 4
- Can't use self-built jar file on spigot 1.21 server HOT 5
- Logs are not saved HOT 7
- [1.21] Crafter inventory isn't rolled back
- 1.21 changes InventoryView from an abstract class to an interface HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coreprotect.