[Feature] Add option to disable Javascript routers about playframework

[PromanSEW]

I am working on PR for this

[mkurz]

@henricook

generateJsReverseRouter := false

in build.sbt (Fully qualified: play.sbt.routes.RoutesKeys.generateJsReverseRouter).

[PromanSEW]

Hmm... I realized that RoutesKeys.generateReverseRouter := false in build.sbt is the one I am looking for.
It disables all reverse routes as I want, nice
So, issue can be closed because this option exists already

[mkurz]

Yes it is no 100% what the original request was, but the problem was solved for Roman.
Anyway, we can re-open to have a separate config to disable javascript routes.

[PromanSEW]

Why Java equivalent for ScalaJavascriptRouting is JavaJavascriptRouter?

[ihostage]

I did not found in documentation how to turn off generation of JavaScript routers It would be nice to have that, for decreasing of unused generated code. Example: REST client (PlayService) without web interface, so JavaScript routers will never be used here.

Hi, Roman! 👋 You are right, it's not possible to turn off right now. But I caught the same thoughts about this opportunity while adding Gradle support and I agree it would be nice to have the related settings. 👍
Would you be keen to provide a pull request for that feature?

[PromanSEW]

OK, I'll try if I have free time soon. If I'm right, here are key places for editing:

playframework/dev-mode/sbt-plugin/src/main/scala/play/sbt/routes/RoutesCompiler.scala

Line 28 in 691a071

val generateReverseRouter = SettingKey[Boolean](

playframework/dev-mode/play-routes-compiler/src/main/scala/play/routes/compiler/RoutesGenerator.scala

Line 72 in 691a071

generateJavaScriptReverseRouters(

The main problem is how integrate new setting into this unfamiliar code for me...

[mkurz]

Perfect!

[ihostage]

So, issue can be closed because this option exists already

I'm not sure that generateReverseRouter settings and subject of this issue is equals 🤔
@mkurz Can you correct me or can I reopen this issue otherwise? 😄

[henricook]

@PromanSEW Would you mind telling me how to disable this in 3.0.2 please? It sounds like it might save some unused code generation in my purely Scala Play project? I didn't see a docs update, please forgive me if you've already documented this somewhere