NPE about leonids

[plattysoft]

It is watched, but so far there has been no need to maintain it. It seems that every crash report on something like that was a misuse coming for a misunderstanding of how it should be used (and I do agree that it is lacking detailed documentation)

Fell free to fix it and submit a PR.

[ryust]

So an NPE within the library's internal code is considered a misuse? How can that be? What is the misuse in the above stacktrace?

[plattysoft]

Maybe I did not express myself correctly.

As far as I know, all the logged issues on github are linked to wrong usage of the library.

I can not tell what you are doing from a stacktrace, without steps to replicate I can't really find or solve the issue.

You can get plenty of NPE on Android and that is not an issue of the framework (i.e. calling getActivity on a detached fragment)

If you give me steps to replicate, I can look into it, just with a stack trace there's not much I can do.

And finally, as I said, I am happy to accept contributions, so if you want to dig into it and submit a PR with a fix I'll be happy to merge it in.

[ryust]

As I indicated, the NPE is random and rare... similar to previous reports. The problem was already documented in issue #43 with a user supplied fix. Since the stacktrace (supplied by Crashlytics) doesn't go deep enough to highlight where in my code it starts, I cannot give a reliable example. The app just has a couple simple onetime particle emits... and the same code works most of the time except for a rare NPE.

Maybe at a minimum wrap the onUpdate in a try/catch to more gracefully handle the NPE regardless of the cause?

[plattysoft]

Feel free to do a patch, try it and it resolved the problem we can integrate it.
As you can see in the code

Leonids/LeonidsLib/src/main/java/com/plattysoft/leonids/ParticleSystem.java

Line 78 in fa10427

public void run() {

The particle system weak reference is only accessed if it is not null, even more, the fact that the previous line executes means that the reference is not null.

Can the reference be turned null between those 2 lines? I can't see how, but as I said, feel free to wrap it on a try/catch and see if that solves the problem. I am reluctant to add something like that to a release just for you to try it out without being sure what is causing it. It may as well surface somewhere else.