Coder Social home page Coder Social logo

FEATURE: VTTablet naming about vitess-operator HOT 3 OPEN

GenLN avatar GenLN commented on July 22, 2024
FEATURE: VTTablet naming

from vitess-operator.

Comments (3)

GenLN avatar GenLN commented on July 22, 2024 1

Mainly reason is for easy monitoring/alerting components. As for vttablets I do monitor each pod on it's metric exposed ports... But for pod/container resource usage is much harder to obtain these labels in metrics(offers pod name or pvc name). Which if it was there would make dashboarding and filtering much easier, also alerting. If I can filter it by keyspace, shard, would show much more meaning info than pod name of the vttablet.
Vttablet pod name doesn't tell the much on first look, it gives you only tablet-uid and cell info aka alias. Also in resource metrics you have the pod name or pvc name which doesn't tell you right information on the first look, like oh it's vttablet of this shard of the keyspace which I need to look to it. Also what I noticed, vttablet label for tablet-type doesn't tell you this is primary vttablet. Didn't notice any of the lables can tell you this is primary. Until I look more deeper, like using vtctldclient to get primary vttablet alias etc..

from vitess-operator.

mattlord avatar mattlord commented on July 22, 2024

I'm not necessarily against the idea, but it's worth noting that labels are the standard way to do this and it allows for using label selectors for filtering. For example:

 kubectl -n <ns> get pods --selector=planetscale.com/component=vttablet,planetscale.com/keyspace=customer,planetscale.com/shard=-80 -L planetscale.com/keyspace,planetscale.com/shard

That is objectively much better than having to use e.g. awk with the list of pod names. I understand that's not as convenient as being able to quickly see it in the pod names with a simple get pods, so I'm not against the idea, but just noting that this would likely have to be a contribution for it to happen.

from vitess-operator.

mattlord avatar mattlord commented on July 22, 2024

The problem you describe in the comment above certainly seems valid to me, but it's also not what I see the issue title and description as being about -- not as I read it anyway. IMO it's better to open an issue that describes the problem you're having in detail rather than proposing a potential solution which you feel might make 1 or more problems better. Make sense? Issue is the problem, a PR would be a proposed solution to the given problem.

from vitess-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.