Lists.immutableList(Iterable) should be named distinctly from immutableList(E) ; (E...) about google-collections

[GoogleCodeExporter]

One solution is to rename immutableList(E) and immutableList(E...) to
immutableListOf(E) and immutableListOf(E...).

Original comment by [email protected] on 11 Oct 2007 at 2:28

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Good point. I especially wouldn't want to have just a small number of issues 
like
this be the only things preventing retrotranslated code from compiling!  (I 
hope it's
going to be only small.)

At this point I am thinking of immutableCopy() or immutableCopyOf().

Original comment by [email protected] on 16 Oct 2007 at 3:54

• Changed title: Lists.immutableList(Iterable) should be named distinctly from immutableList(E) ; (E...)
• Changed state: Accepted

[GoogleCodeExporter]

The names I'm leaning toward now are

ImmutableArrayList.of()
and
ImmutableArrayList.copyOf()

and the same for ImmutableHashSet, and this is what I would submit to be in
java.util.  Any comments?

Original comment by [email protected] on 29 Nov 2007 at 1:18

[GoogleCodeExporter]

Those names imply that you're returning an ArrayList. If the List contains 0 or 
1
elements, you might want to return a different class for optimal performance.

Original comment by [email protected] on 29 Nov 2007 at 2:22

[GoogleCodeExporter]

You're right!  I should call the class ImmutableList (after all, an array is 
the only
sensible way you'd want to back it when n > 1 anyway, so 'array' in the name is
pointless).

Now, note that even my method named copyOf() is, I think, entitled to be 
sneaky; if
you pass it an ImmutableList instance it *won't* actually copy anything; it 
will just
return you the same instance.  I think this is ok and the name is still 
appropriate
because it's a copy in any way that can really matter.

Original comment by [email protected] on 29 Nov 2007 at 2:38

[GoogleCodeExporter]

What about ImmutableList.of for a single element and ImmutableList.from for the 
Iterable?

Original comment by Ben.Lings on 11 Jan 2008 at 10:14

[GoogleCodeExporter]

ImmutableList.from() is not a bad suggestion but we ended up sticking with 
copyOf().
 This code is pushed now so I'm closing the issue.  Thanks!

Original comment by [email protected] on 24 Mar 2008 at 8:25

• Changed state: Fixed