Comments (4)
@mariusz2108 I agree that this is quite inefficient; however, implementing this isn't straight forward due to the way HomeKit requests information.
The way I can see around it is for there to be a central function called something like getStatus
which will do the one request; then, when a variable is requested e.g. getTargetTemperature
, it asks the getStatus
function for this info rather than requesting it directly from the thermostat. However, the central function must ensure that the info is up-to-date.
Like I said, I agree that this would be an improvement and I'm interested in looking into implementing this into my fork of the plugin in the near future then creating a pull request into the main branch.
Best, Tom
from homebridge-thermostat.
I also agree, but according on how you will ask SIRI/Home App information, you will still have 4 Calls. Indeed, we can separate the call to get a lighter payload, but at the time I did the plugin, I didn't saw much difference.
And then I think about all the peoplle the have a working API that could be broken with a new implementation.
Do you think this is really an issue ?
@Tommrodrigues, if you do a PullRequest (what can be nice) I will wrap it into a new version. V1.X.X
Thx
from homebridge-thermostat.
I have made POC with "caching" results and it makes huge difference for me (my home bridge runs on raspberry pi).
First request gets data and save it.
Then I start timer for one minut.
Sice now for one minute every request is taken from "cache".
I am not sure if it's good solution since I don't know well JS. But it works.
from homebridge-thermostat.
from homebridge-thermostat.
Related Issues (20)
- homebridge doesnt get the data HOT 3
- dummy thermostat HOT 5
- Does thermostat support adjust the fan state? HOT 1
- Error: connect EALREADY HOT 4
- Thermostat not working with Siri, but OK with Home app HOT 3
- Can't get it working with Infinitude HOT 5
- No Response error HOT 2
- Pull request not merged HOT 2
- Fake.js not working HOT 2
- CurrentTemperature rounded to whole number HOT 7
- getting error message HOT 5
- Significant Variance in Temperatures in Home App HOT 3
- One click activation of thermostat devices HOT 3
- Work with Honeywell home t series thermostats HOT 1
- heatOnly option HOT 10
- pollInterval does not work HOT 5
- Cannot pair Homebridge bridge in Home app when homebridge-thermostat accessories are present in config.json HOT 1
- "heatOnly": true - ignores auto mode HOT 1
- Not working with Dantherm
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from homebridge-thermostat.