Coder Social home page Coder Social logo

Comments (10)

rainypixels avatar rainypixels commented on August 16, 2024 2

UPDATE:
For anyone with the same question, I ran pod update --verbose and realized the 3.0.2 branch of PINCache was being fetched (while the fix is in master). Adding the following to the podfile fetches the right versions with imports fixed:

pod 'PINCache', :git => 'https://github.com/pinterest/PINCache.git', :branch => 'master'


@garrettmoon I saw that you fixed this issue and merged to master (πŸ™) but the update doesn't seem to reflect in Texture which specifies PINCache as a dependency. That’s still pulling the .m files with @import PINOperation;. Apologies if I'm missing something stupid. 😬

from pincache.

garrettmoon avatar garrettmoon commented on August 16, 2024 1

UPDATE:
For anyone with the same question, I ran pod update --verbose and realized the 3.0.2 branch of PINCache was being fetched (while the fix is in master). Adding the following to the podfile fetches the right versions with imports fixed:

pod 'PINCache', :git => 'https://github.com/pinterest/PINCache.git', :branch => 'master'

@garrettmoon I saw that you fixed this issue and merged to master (πŸ™) but the update doesn't seem to reflect in Texture which specifies PINCache as a dependency. That’s still pulling the .m files with @import PINOperation;. Apologies if I'm missing something stupid. 😬

You're not missing anything – it takes us time to cascade releases all the way down to Texture. I'm working on making this easier so we take less time!

from pincache.

internalG avatar internalG commented on August 16, 2024 1

Fixed with 3.0.3.

from pincache.

Braindie avatar Braindie commented on August 16, 2024

+1

from pincache.

iwheelbuy avatar iwheelbuy commented on August 16, 2024

I believe something is wrong with pod 'PINCache', '3.0.2'

def pod__PINRemoteImage
  pod 'PINRemoteImage', '3.0.1', :modular_headers => true
  pod 'PINCache', '3.0.1', :modular_headers => true
end

This way it works for me.

from pincache.

garrettmoon avatar garrettmoon commented on August 16, 2024

What version of Xcode are you using? Can you upload a sample project demonstrating the issue?

from pincache.

iwheelbuy avatar iwheelbuy commented on August 16, 2024

@garrettmoon 12 GM or 12.0.1 - both don't work.
PIN.zip

from pincache.

yang152412 avatar yang152412 commented on August 16, 2024

The @import PINOperation; change bring this error to project. The SPM support breaks objc project.

+1

from pincache.

luoshihui avatar luoshihui commented on August 16, 2024

The @import PINOperation; change bring this error to project. The SPM support breaks objc project.

+1

from pincache.

internalG avatar internalG commented on August 16, 2024

The podfile to reproduce the issue:

platform :ios, '8.0'
inhibit_all_warnings!
target 'pname' do
pod 'AFNetworking/NSURLConnection', '~> 2.0'
pod 'PINCache'
end

post_install do |installer|
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
if config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].to_f < 8.0
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '8.0'
end
end
end
end

from pincache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.