Ingress - `semverCompare` is not getting the correct k8s version. about helm-charts

[jjustinic]

I think it's having issue with the handling of the version there that includes the +. It does work when the version is just 1.19 instead of 1.19+:

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.12", GitCommit:"2cb4598553d0a2ca5f3eb7980c99cd8236cc5011", GitTreeState:"clean", BuildDate:"2021-06-16T13:00:29Z", GoVersion:"go1.15.13", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.11", GitCommit:"d062c7ef8a88e89e5f28f1c1146bd707d00d4881", GitTreeState:"clean", BuildDate:"2021-11-01T16:41:06Z", GoVersion:"go1.15.12", Compiler:"gc", Platform:"linux/amd64"}

I'm not sure in this case version really matters though. I would think just checking for the availability of the stable v1 over v1beta1 would be good enough. I don't get a say though. This was just earlier discussion and testing closely related in my #175.

[wesleymccollam]

@topijag I've made changes in this commit. Would you mind verifying if this change works locally for you? If you clone the dev branch, you can run a command pointing to your local charts (below).

helm upgrade --install <release name> charts/ping-devops -f <.yaml>

[topijag]

Thanks @wesleymccollam for the change, I'll test it!
I'm facing this as well, kubernetes/kubernetes#94761 (comment)

Despite the fact of using the proper apiVersion, the deprecated one is still being seen as the the default one 🤦

[wesleymccollam]

@topijag, I've added another commit that should take care of the warning message. The template code was checking against 1.18.x instead of 1.19.x for the Kubernetes Version.

[topijag]

It looks like this is missing in:

-{{- if semverCompare ">=1.19.x" $top.Capabilities.KubeVersion }}
+{{- if semverCompare ">=1.19.x" $top.Capabilities.KubeVersion.Version }}

https://github.com/pingidentity/helm-charts/blob/dev/charts/ping-devops/templates/pinglib/_ingress.tpl#L7

[wesleymccollam]

@topijag, excellent catch. I've updated this for the next release which should go out later today or tomorrow.