Comments (3)
Reproduced.
Windows 10 Pro 21H1
[email protected]
[email protected] and [email protected]
Got the same error for both versions of npm:
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@uploadthing%2feslint-config - Not found
npm ERR! 404
npm ERR! 404 '@uploadthing/[email protected]' is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
I changed line 22 in ./package.json
from:
"@uploadthing/eslint-config": "0.1.0",
to:
"@uploadthing/eslint-config": "file:./common/eslint-config-custom",
That allowed the package to install. But then running npm run build
gave the following error:
build
turbo run build• Packages in scope: @example/appdir, @example/pagedir, @uploadthing/eslint-config, @uploadthing/react, @uploadthing/tsconfig, docs, uploadthing
• Running build in 7 packages
• Remote caching disabled
uploadthing:build: cache miss, executing c55d788e4ca361d5
docs:build: cache miss, executing bf964c276951d810
uploadthing:build: ERROR: command finished with error: exec: "pnpm": executable file not found in %PATH%
exec: "pnpm": executable file not found in %PATH%Tasks: 0 successful, 2 total
Cached: 0 cached, 2 total
Time: 1.766sERROR run failed: command exited (1)
Seems like turbo
is seeing pnpm-lock.yaml
and pnpm-workspace.yaml
and using pnpm
as its command, which is a sensible guess. I don't know enough about turborepo to say for sure, but it seems like making this able to build with multiple package managers is going to involve multiple lock files that could fall out of sync with each other. Might be better to just specify that pnpm
is mandatory in the README.
from uploadthing.
There's a potentially relevant comment here: vercel/turbo#1630 (comment):
In this scenario you have a pnpm-lock.yaml and a package-lock.json in the root.
No matter what we attempt to detect it will make somebody unhappy. There is no reasonable way for us to ensure that we guess correctly in this situation.
We provide a method to skip that inference by specifying packageManager and no matter what we decide to do, that will be a requirement in this scenario.
I think this means that the only way to support multiple package managers in a turborepo project is:
- Remove
"packageManager": "[email protected]"
from yourpackage.json
- Add
package-lock.json
,yarn.lock
, andpnpm-lock.yaml
to your.gitignore
- Proceed to do the actual testing and debugging to verify your commands all work with each package manager
So.... sounds like sticking with pnpm and closing this issue is the way to go.
from uploadthing.
Seems like turbo is seeing pnpm-lock.yaml and pnpm-workspace.yaml and using pnpm as its command
Yes, we use pnpm as our package manager here. You shouldnt use npm or yarn when developing in this repo. I thought the packageManager
field restricted this? Of maybe npm doesnt respect that 🙄
We dont have a contributing guide but we probably should add some quick steps on how to get going.
Closing this.
from uploadthing.
Related Issues (20)
- [Bug]: Unable to delete account HOT 5
- feat: add us-east-1 N. Virginia HOT 4
- [misc]: Sending presigned URLs to client stuck HOT 3
- [misc]: Vercel preview URLs make up all the top search results for upload thing docs HOT 1
- feat: add ap-southeast-1 Singapore HOT 1
- RFC: What regions would you like to see us add to Uploadthing? HOT 2
- feat: Ability to export multiple images as a CSV or JSON HOT 2
- feat: More restrictive MIME types for better UX uploading images from Android HOT 3
- [bug]: Error uploading the file in NextJs
- [bug]: startUpload doesn't return a response. It gives an error. Even though in the console(GUI), it shows the upload was successful HOT 7
- [Bug]: Charset not set properly HOT 3
- [Bug]: your file filters are broken
- onUploadProgress of useUploadThing going back to previous value HOT 1
- feat: rename files through gui HOT 4
- [bug]: Effect package version mismatch? HOT 4
- [misc]: Module '"uploadthing/client"' has no exported member 'UploadFileResponse'.ts(2305) HOT 9
- [misc]: add pnpm catalogs
- [billing]: How do I pay for org plan instead of personal? HOT 3
- [Bug]: `UTApi` is deleting the file but still able to directly access the file from its URL. HOT 5
- [misc]: Can still request file urls for deleted files HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uploadthing.