Feat: Add onUploadBegin prop to UploadButton about uploadthing

[markflorkowski]

We definitely want to add an onUploadProgress() callback. I'll have to think a bit more about onUploadBegin(), but I think it makes sense as well.

[Mr0Bread]

@markflorkowski onUploadBegin prop had been released. I guess this issue can be closed now

[markflorkowski]

onUploadBegin has been added as of v5.4.0 🙌

[irtaza9]

The better should be to have all the features like onuploadprogress and onuploadbegins, etc. I think axios is offering onuploadprogress callback.

[irtaza9]

Cool, let me know if you guys need any help. I'll be happy to add my part.

[markflorkowski]

Feel free to open a PR if you have ideas on this and want to contribute! Otherwise, i have put this in our backlog to be addressed soon(tm)

[irtaza9]

I was thinking about it but It's tough

[markflorkowski]

I am thinking if we use XHR instead of fetch, it has onprogress built in, which could work. Alternatively we could do uploads as multipart, and use the completion of each part to update the progress.

[irtaza9]

And that is what I want to suggest but I thought all the package is build around fetch may be you people don't go for XHR. btw what about axios?

XHR:

   const xhr = new XMLHttpRequest();
   xhr.addEventListener("loadstart", handleEvent);
   xhr.addEventListener("load", handleEvent);
   xhr.addEventListener("loadend", handleEvent);
   xhr.addEventListener("progress", handleEvent);
   xhr.addEventListener("error", handleEvent);
   xhr.addEventListener("abort", handleEvent);

helper-fun

   function handleEvent(e) {
      console.log(e.loaded)
   }

I got this resource over mdn

[ryanpratama14]

onUploadBegin is not working somehow...

"uploadthing": "^6.0.3",
"@uploadthing/react": "^6.0.2",

[Shijel]

@ryanpratama14 Same here

"uploadthing": "^6.0.4"
"@uploadthing/react": "^6.0.2",

[markflorkowski]

Yeah looks like we broke it when we introduced multipart uploads. Will be fixed in the next release.