Coder Social home page Coder Social logo

Comments (3)

pimterry avatar pimterry commented on May 19, 2024

Hmmm. The core problem isn't that we're creating and destroying methods, it's actually that we're not creating any methods; all that happens is log.info gets assigned to a bound version of console.info, when you call setLevel, or a single noop method that gets assigned to it instead (see loglevel.js lines 124-126)

This can't stop happening; doing that rather than wrapping the function in a method that looks at the level and then calls the appropriate method is what stops it from clobbering the stacktraces. If you wrap the methods, then chrome and firefox shows the message as coming from inside loglevel, rather than from whichever line you actually called it from (which is extremely annoying).

I do see you use case though, that makes sense. Any other suggestions for methods to fix this?

from loglevel.

sporto avatar sporto commented on May 19, 2024

I haven't thought about the stacktraces consideration at all, that is definitely important. I don't have any suggestions for the moment. Will have another look later on.

from loglevel.

pimterry avatar pimterry commented on May 19, 2024

For now I'm going to close this. Do feel free to shout (either @sporto or anybody else) if you disagree, I'm very happy to reopen it if anybody can think of any other options that do support this use case.

from loglevel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.