Coder Social home page Coder Social logo

Comments (5)

dbartle avatar dbartle commented on May 30, 2024

Thanks for the report, this makes sense. It should close it down entirely when release() is called, for sure.

"Is possible when call pause() release microphone and on resume() reattach it?"

I think it would make more sense to create a new method stop() that destroys the microphone and keep pause() working as-is. Re acquiring the stream might hurt latency and cause some difficulties for the deps that assume pause/resume is essentially instant/cheap. Then start can be re-worked to re-acquire the stream, if necessary.

from web-voice-processor.

SampoliDev avatar SampoliDev commented on May 30, 2024

That's right, it makes more sense to create a stop method and reacquire the microphone with start

from web-voice-processor.

dbartle avatar dbartle commented on May 30, 2024

This has been fixed in v2.0.3. Calling release() will now stop the media tracks.

I haven't yet added a stop() method, because it will lead to behaviour that requires a lot more testing and changes, because it modifies the underlying assumption that once a WebVoiceProcessor instance exists, it has already successfully completed the async mic acquisition. We can look at doing that in a separate issue/task potentially.

from web-voice-processor.

dbartle avatar dbartle commented on May 30, 2024

The Vue binding has also been updated. The web-voice-processor has been set to a peerDependency, so this means that it will need to be explicitly installed, but now it should be less coupled to the binding.

from web-voice-processor.

dbartle avatar dbartle commented on May 30, 2024

I'm going to close this as the issue is resolved for the original topic.

from web-voice-processor.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.