Coder Social home page Coder Social logo

Comments (8)

sinisaos avatar sinisaos commented on June 22, 2024 1

@dantownsend Can you please close this issue because it's done with latest changes.

from piccolo_api.

wmshort avatar wmshort commented on June 22, 2024

@dantownsend great addition. 👍 What's the relationship between the query string (__fields) and the returned JSON key ('rows' in your example)? Are they meant to match?

from piccolo_api.

dantownsend avatar dantownsend commented on June 22, 2024

@wmshort Yeah, they're meant to match. The top level rows key is always the same, but the sub elements should have their keys filtered based on the __fields parameter, if that makes sense.

from piccolo_api.

wmshort avatar wmshort commented on June 22, 2024

@dantownsend definitely. I was just wondering about what seemed like a mismatch between that top level key ("rows") and the parameter "fields" in the query. But obviously the result consists of (only) the specified fields of the fetched rows, so your naming scheme makes good sense. The request is for table rows, constrained by certain parameters. Looking forward to this feature 🙂

from piccolo_api.

dantownsend avatar dantownsend commented on June 22, 2024

@wmshort This feature is pretty much done now, except I'm not sure on the naming of the parameter.

What do you think is most suitable? __fields, __columns, __visible_fields?

from piccolo_api.

wmshort avatar wmshort commented on June 22, 2024

Personally I find 'fields' the most intuitive but any of these will be clear enough. Glad this has come together. Nice!

from piccolo_api.

dantownsend avatar dantownsend commented on June 22, 2024

@wmshort Thanks - naming stuff is hard! It's good to have a sanity check.

from piccolo_api.

dantownsend avatar dantownsend commented on June 22, 2024

Fixed by #98

from piccolo_api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.