Comments (8)
@dantownsend Can you please close this issue because it's done with latest changes.
from piccolo_api.
@dantownsend great addition. 👍 What's the relationship between the query string (__fields) and the returned JSON key ('rows' in your example)? Are they meant to match?
from piccolo_api.
@wmshort Yeah, they're meant to match. The top level rows
key is always the same, but the sub elements should have their keys filtered based on the __fields
parameter, if that makes sense.
from piccolo_api.
@dantownsend definitely. I was just wondering about what seemed like a mismatch between that top level key ("rows") and the parameter "fields" in the query. But obviously the result consists of (only) the specified fields of the fetched rows, so your naming scheme makes good sense. The request is for table rows, constrained by certain parameters. Looking forward to this feature 🙂
from piccolo_api.
@wmshort This feature is pretty much done now, except I'm not sure on the naming of the parameter.
What do you think is most suitable? __fields
, __columns
, __visible_fields
?
from piccolo_api.
Personally I find 'fields' the most intuitive but any of these will be clear enough. Glad this has come together. Nice!
from piccolo_api.
@wmshort Thanks - naming stuff is hard! It's good to have a sanity check.
from piccolo_api.
Fixed by #98
from piccolo_api.
Related Issues (20)
- Python 3.11 support
- Extend `db_exception_handler` to handle not-null exceptions
- CRUD Endpoint POST response is a list HOT 9
- Starlite support HOT 17
- Feature Request: Instead of just exposing the crud endpoints, can it generate the actual methods in a file? HOT 2
- Be able to sort by multiple columns in `PiccoloCRUD`
- Add `allow_unauthenticated` to `JWTMiddleware`
- TypeError: __init__() got an unexpected keyword argument 'excluded_paths' HOT 5
- Feature to modify body and query_parameters in `PiccoloCRUD` HOT 8
- Fix code scanning alert - Unused global variable
- Batch version of the get endpoint HOT 6
- Drop Python 3.7 support
- Catch foreign key constraint errors in `PiccoloCRUD`
- `schema_extra` param not passed to `pydantic_model_{output | optional | plural}` methods HOT 1
- Piccolo Admin API docs are not rendering
- Better error display on PATCH request
- Alpha version for Pydantic 2.0 / Piccolo 1.0a1? HOT 2
- PiccoloCRUD `post_single` return id of the inserted row instead of the row HOT 3
- Add `ne` operator
- Python 3.12 support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from piccolo_api.