Comments (9)
@wmshort I know that Pydantic was recently updated, which might be the cause of the issue.
Have you tried using an explicit model_name
with create_pydantic_model
? I've encountered an issue before with FastAPI and Pydantic which was solved by this.
create_pydantic_model(SomeTable, model_name="my_unique_model_name")
It's a shot in the dark, but might help.
I'll try and replicate the issue.
from piccolo_api.
I had the same thought, but in fact I was doing that already on the models, so it couldn't have been causing the problems. I did just see somewhere else that having an Enum of the same name on two models might cause the issue! I do have this on my models, so I'm going to try this change.
No effect. :(
from piccolo_api.
@wmshort I can replicate your KeyError
problem only if I do not use the explicit model_name
with create_pydantic_model
. If I use model_name
everything is fine. FastAPIWrapper
works fine. Both Python3.7 and Python3.8 with latest FastAPI (v0.71.0)
, Pydantic (v1.9.0)
and latest Piccolo
. Can you show us your schema from tables so we can try it out?
from piccolo_api.
@sinisaos Thanks for taking a look.
I tried updating my apps to the latest FastAPI, and it seems OK. So the bug must be quite subtle.
@wmshort The only other things I can think of at the moment are:
- Make sure
model_name
matches the variable name. SoMyModel = create_pydantic_model(SomeTable, model_name="MyModel")
. - Make sure
create_pydantic_model
is called within the global scope, and not within a function or something.
from piccolo_api.
@dantownsend William sent me his schema and the only thing I noticed is that in Python 3.7 (which William uses as seen from the error logs) we MUST use model_name
because post
and put
routes are a problem (they use SomeModelIn
and SomeModelOut
if we write endpoints by ourselves) . In Python 3.8 we don't have to use model_name
and everything work fine. I don't know if it will solve the William problem but I don't see anything else.
from piccolo_api.
@sinisaos OK, thanks for checking. If it works for Python 3.8 and above, that's definitely helpful to know.
from piccolo_api.
Thanks, both. All of these conditions are true already, apart from the Python version. I'll give that a try. Otherwise it's probably some corner case and I'll have to experiment some with model_name
. Is there any chance it has to do with nested
and some naming clash there?
from piccolo_api.
@wmshort Yes, nested could be the cause.
from piccolo_api.
After a little more experimentation I've narrowed the problem down to two tables that both have two ForeignKey fields referencing the same table. (Though in each case, the referenced table is different). It doesn't appear to be nested
per se as certain nested tables that do not have the 'two FKs pointing to the same table' issue work perfectly well. So the problem actually seems to be related to the case of a table like:
class BattleOfTheBands(Table):
band1 = ForeignKey(references=Band)
band2 = ForeignKey(references=Band)
which does not appear to play nice with Pydantic, at least under my configuration. Strange, as I am now using Python 3.8 and latest versions of dependencies, which worked for @sinisaos. I'm stumped!
from piccolo_api.
Related Issues (20)
- Batch version of the get endpoint HOT 6
- Drop Python 3.7 support
- Catch foreign key constraint errors in `PiccoloCRUD`
- `schema_extra` param not passed to `pydantic_model_{output | optional | plural}` methods HOT 1
- Piccolo Admin API docs are not rendering
- Better error display on PATCH request
- Alpha version for Pydantic 2.0 / Piccolo 1.0a1? HOT 2
- PiccoloCRUD `post_single` return id of the inserted row instead of the row HOT 3
- Add `ne` operator
- Python 3.12 support
- RateLimitingMiddleware tests failed HOT 5
- Stop multi-dimensional arrays from breaking
- Issue with updating and bulk updating `BaseUser` via admin panel HOT 15
- Updating middleware syntax HOT 6
- Make `default-src` configurable in `CSPMiddleware`
- Hide parameter in Validators to hide Piccolo Admin table link from sidebar if the validators fail. HOT 8
- Add `excluded_paths` to `SessionsAuthBackend`
- Replace deprecated `abstractproperty`
- Fix for Pydantic breaking changes HOT 2
- Hooks Outside PiccoloCrud HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from piccolo_api.