Comments (9)
So, we have a security hole? I don't fully understand what he wants us to do.
from web.
No, I've never been entirely sure what it is. @jacobsalmela tagged it as an enhancement, so I figured he knew what it was about...
from web.
Seems like you tag includes for CSS/JS that are not served by yourself?
from web.
Isnit not just the cdns for jquery and bootstrap?
from web.
I just tagged it as an enhancement, but didn't fully look at it. I guess I don't fully understand what he wanted--something to do with it being coded insecurely, which his department cannot work with, however, I had trouble understanding the original request. If @Mcat12 doesn't know what he means, than I don't know that the rest of us will. I just wanted to eliminate any security issues if there really is one.
from web.
I think he may be taking about some JavaScript thing where using "eval" (runs JavaScript code in it's parameter, ex eval("1+1")) is very unsafe, because you can run any code you want. I don't think there's a security issue though, as JavaScript is run client side. If there is, it would be nice for him to elaborate.
from web.
@magarto, can you elaborate on what you meant in your original issue? We are a bit confused.
from web.
I just came back to this issue, and I think I understand a bit of what he's saying. This link he shared does a good summary. Basically, we should move all Javascript to their own files and remove JS code in the html (onclick, etc) and instead use event handlers.
from web.
Cool, that makes more sense.
from web.
Related Issues (20)
- Query Log table - long client names create a horizontal scrollbar in boxed layout
- Click on query log details causes Uncaught TypeError HOT 1
- Group assignment dropdown not always populated HOT 4
- Local DNS records and CNAME don't show pagination buttons HOT 11
- After clicking on the +/- icon they keep the "active" state making them nearly invisible with dark theme HOT 1
- After datatables update, tables are no longer striped HOT 1
- Save button on boxed layout outside of content area HOT 1
- SQL-Error on fresh installation on Raspberry HOT 3
- Web GUI add domain to whitelist / blacklist is added only in default group HOT 1
- No log in for a week HOT 7
- admin/scripts/pi-hole/php/customdns.php and admin/dns_records.php: CORS is something the browser handles, not the server HOT 3
- CNAME records not imported to v6 from v5 Teleport file HOT 5
- /admin/scripts/pi-hole/php/customdns.php persistently fails even with password disabled HOT 2
- Update Gravity page is redirect depending on the settings level HOT 1
- An entry in the blacklist is not being blocked HOT 10
- Mapping 2 MAC addresses to the same IP address not displayed correctly on web HOT 2
- "Total queries over last 24 hours" empty HOT 4
- NAN on Admin Stats with Multiple Containerized Pihole Admin Consoles HOT 15
- Glow effect in "Total Queries" box result in blurry text. HOT 5
- Universal Time Displayed in Firefox Instead of Local Time HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web.