Comments (5)
Hey Igor, that is a really good insight.
However, as you probably know, this is not universal. There could be valid falsy values in the array, like ['', 0]
. Which this would mark as empty.
However, seeing how fast a.lenght
is, maybe it makes sense to add this before the keys check, WDYT?
from 1loc.
Yeah, exactly, falsy. How I could forget!
I think there is still need filter function and therefore I suppose better solution wich cover edge cases is
Array.isArray(a) && a.length > 0 && a.filter(el => el === undefined)
Also checking can be faster if use latest ES2020 feature (link):
For history: my jsperf test from initial message https://jsperf.com/object-keys-vs-array-length
from 1loc.
Can you make a PR?
from 1loc.
Yes of course
from 1loc.
from 1loc.
Related Issues (20)
- Convert URL parameters to object
- JSON.stringify a Object with circular references HOT 1
- isEqual is buggy HOT 2
- "Check if an array is empty" is incorrect
- Compare two arrays regardless of order has siteeffects HOT 4
- Mobile view not responsive HOT 1
- [FEAT] Add a search bar to find snippets HOT 1
- [DOCS] Add a `CONTRIBUTING.md`
- [CHORE] Add issue and pull request templates
- what is the diffrence between <T> and <T, _> HOT 3
- fool questions HOT 1
- Missing depth parameter to Array.prototype.flat method HOT 3
- Questions about submitting code after approval
- About Contribution
- Compare two arrays regardless of order is simply incorrect
- "npm i" failed HOT 1
- No style after startup
- [FEATURE] Pluralise based on length of array. HOT 5
- wrap() is wrong HOT 1
- Add "eleventy" as a topic on GitHub repo page HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 1loc.