Copy with rsync without using the detele flag is dangerous about composer-stager

[TravisCarden]

Hi, @bbrala. Sorry for the late reply. I guess I wasn't subscribed to issues.

We're aware of this issue. We just haven't gotten to it yet. If we get it wrong, we could cause data loss, so we need to be careful. I'll leave this issue open to track it.

[bbrala]

No problem, i understand it is a bit tricky. In the end it is needed though since left over files will break some packages that might use some form of plugin discovery.

We use rsync with deletion for these kind of things. But assuming rsync is probably nor an option :)

[TravisCarden]

In the end it is needed though since left over files will break some packages that might use some form of plugin discovery.

Most definitely.

But assuming rsync is probably nor an option :)

Exactly: 😃

composer-stager/src/Infrastructure/Process/FileCopier/FileCopierFactory.php

Lines 37 to 43 in 5ebeab9

	public function create(): FileCopierInterface
	{
	if ($this->executableFinder->find('rsync') !== null) {
	return $this->rsyncFileCopier;
	}
	return $this->symfonyFileCopier;
	}

[bbrala]

👍