Comments (8)
from cli-menu.
Hmm. Actually, this is already non-issue on the dev-master branch, rather than the most recently published version. It's already been fixed there.
from cli-menu.
Ok I've reverted it. I'll prepare a new release next week with the existing fix.
from cli-menu.
It's fixed in master, just not released
from cli-menu.
Certainly sounds like a bug, feel free to send a PR with a fix, otherwise I'm not quite sure when we'll get around to fixing. Regarding the echoing not working, we could maybe catch any errors or register a shutdown function to do similar to what \PhpSchool\CliMenu\CliMenu::tearDownTerminal
does. What do you think?
from cli-menu.
I've been looking into the root cause, and I've found it, before PHP 8, substr returns false in certain circumstances. The type of the return value from the substr call on line 78 of InputIO.php isn't checked. A relatively simple solution should work, something like:
'if (!is_string($inputValue)) {
$inputValue = ''
}'
And, yes it would probably be a good idea to have a shutdown function that restores the terminal.
from cli-menu.
Sounds good to me :)
from cli-menu.
In version 4.3 this problem still exists.
from cli-menu.
Related Issues (20)
- struggling to re-generate sub-menu dynamically HOT 6
- Custom and auto mappings can't override default HOT 18
- Menu Dialog HOT 12
- Menu blink because deprecated warning. HOT 4
- Terminal overflow and menu size HOT 2
- Checked checkbox HOT 3
- Windows compatibility: replace posix_isatty() with stream_isatty() HOT 5
- Menu items and cp1251 HOT 3
- setPromptText - multiline support HOT 5
- PHPStorm - How to debug HOT 3
- PHPUnit problem if first item is not a SelectableItem which calls ->close() HOT 2
- Don't work setWidth() for MenuStyle HOT 4
- askText() requires two presses of enter and cuts the line (during copy/paste) HOT 1
- Missing import HOT 3
- Replace ctype_digit with is_numeric ? HOT 2
- Feature request - ability to add sub-menu from addItem's callable HOT 9
- How do I capture CTRL+C event? HOT 2
- preserving selection index as you move up/down
- Feature: present menu "inline"; without clearing terminal screen HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli-menu.