Coder Social home page Coder Social logo

Comments (8)

tbannister avatar tbannister commented on June 12, 2024 1

#267

from cli-menu.

tbannister avatar tbannister commented on June 12, 2024 1

Hmm. Actually, this is already non-issue on the dev-master branch, rather than the most recently published version. It's already been fixed there.

from cli-menu.

AydinHassan avatar AydinHassan commented on June 12, 2024 1

Ok I've reverted it. I'll prepare a new release next week with the existing fix.

from cli-menu.

AydinHassan avatar AydinHassan commented on June 12, 2024 1

It's fixed in master, just not released

from cli-menu.

AydinHassan avatar AydinHassan commented on June 12, 2024

Certainly sounds like a bug, feel free to send a PR with a fix, otherwise I'm not quite sure when we'll get around to fixing. Regarding the echoing not working, we could maybe catch any errors or register a shutdown function to do similar to what \PhpSchool\CliMenu\CliMenu::tearDownTerminal does. What do you think?

from cli-menu.

tbannister avatar tbannister commented on June 12, 2024

I've been looking into the root cause, and I've found it, before PHP 8, substr returns false in certain circumstances. The type of the return value from the substr call on line 78 of InputIO.php isn't checked. A relatively simple solution should work, something like:
'if (!is_string($inputValue)) {
$inputValue = ''
}'

And, yes it would probably be a good idea to have a shutdown function that restores the terminal.

from cli-menu.

AydinHassan avatar AydinHassan commented on June 12, 2024

Sounds good to me :)

from cli-menu.

dvlpr91 avatar dvlpr91 commented on June 12, 2024

In version 4.3 this problem still exists.

from cli-menu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.