Comments (6)
Sounds like an issue with how Citizens implements their NPCs. Imo such fake players should not appear in the Bukkit API's World.getPlayers() method. Really sounds like a design flaw of that plugin to me.
If they are not willing to fix it I might take a look into how I can combat this.
from betterbeds.
You're right, thanks.
from betterbeds.
@Phoenix616 They /don't/ appear in the Bukkit getPlayers() method though.
from betterbeds.
@mcmonkey4eva Bukkit.getPlayers() is not the method I use. I only use World.getPlayers() (as stated before) and if my plugin somehow registers Citizens' NPCs they have to appear in this method.
from betterbeds.
@Phoenix616 Here's the source code for World.getPlayers() in Bukkit:
public List<Player> getPlayers() {
List<Player> list = new ArrayList<Player>();
for (Object o : world.entityList) {
if (o instanceof net.minecraft.server.Entity) {
net.minecraft.server.Entity mcEnt = (net.minecraft.server.Entity) o;
Entity bukkitEntity = mcEnt.getBukkitEntity();
if ((bukkitEntity != null) && (bukkitEntity instanceof Player)) {
list.add((Player) bukkitEntity);
}
}
}
return list;
}
It literally scans the entire world entity list for players, rather than, y'know, anything remotely logical.
It's also entirely impossible for us to remove NPCs from this list.
I recommend switching to Bukkit.getPlayers() which is theoretically more efficient (a few thousand fold) for both efficiency and compatibility. You could easily filter that list based on world if needed.
from betterbeds.
Welp, that method really doesn't look nice. I guess that's another thing I get to fix in foreign projects -.-
I guess I have to migrate to the other method for now.
from betterbeds.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from betterbeds.