NPCs count as players for calculation about betterbeds

[Phoenix616]

Sounds like an issue with how Citizens implements their NPCs. Imo such fake players should not appear in the Bukkit API's World.getPlayers() method. Really sounds like a design flaw of that plugin to me.

If they are not willing to fix it I might take a look into how I can combat this.

[Xericore]

You're right, thanks.

[mcmonkey4eva]

@Phoenix616 They /don't/ appear in the Bukkit getPlayers() method though.

[Phoenix616]

@mcmonkey4eva Bukkit.getPlayers() is not the method I use. I only use World.getPlayers() (as stated before) and if my plugin somehow registers Citizens' NPCs they have to appear in this method.

[mcmonkey4eva]

@Phoenix616 Here's the source code for World.getPlayers() in Bukkit:

    public List<Player> getPlayers() {
        List<Player> list = new ArrayList<Player>();

        for (Object o : world.entityList) {
            if (o instanceof net.minecraft.server.Entity) {
                net.minecraft.server.Entity mcEnt = (net.minecraft.server.Entity) o;
                Entity bukkitEntity = mcEnt.getBukkitEntity();

                if ((bukkitEntity != null) && (bukkitEntity instanceof Player)) {
                    list.add((Player) bukkitEntity);
                }
            }
        }

        return list;
    }

It literally scans the entire world entity list for players, rather than, y'know, anything remotely logical.

It's also entirely impossible for us to remove NPCs from this list.

I recommend switching to Bukkit.getPlayers() which is theoretically more efficient (a few thousand fold) for both efficiency and compatibility. You could easily filter that list based on world if needed.

[Phoenix616]

Welp, that method really doesn't look nice. I guess that's another thing I get to fix in foreign projects -.-

I guess I have to migrate to the other method for now.