Coder Social home page Coder Social logo

Comments (5)

daveaglick avatar daveaglick commented on May 23, 2024

I’m not sure that’s possible - at least not without dumping the XML to disk as a temporary project file and loading from that. Even without a tweaker, we still manipulate the XML in some cases before loading and I’d like to reserve the option of doing other transformations before load in the future if needed.

IIRC, Buildalyzer does try and tell MSBuild about the filename and location. Perhaps there’s a way (even if means using reflection or other dark magic) to populate whatever MSBuild needs to populate those properties. Or could we just set all of them ourself?

from buildalyzer.

dfederm avatar dfederm commented on May 23, 2024

@daveaglick You're right that Buildalyzer attempts to set the FullFilePath, and I suspect a re-evaluate after setting that may populate these properties, but that happens after the initial load. If the initial load requires these properties (ie. used in Imports), loading may fail.

from buildalyzer.

daveaglick avatar daveaglick commented on May 23, 2024

Ah, think I got it - so we’ve got to get those set during initial load and not via evaluation sometime later. I’d still like to find a way to do this via a stream instead of the file system - hopefully there’s way.

from buildalyzer.

jirikopecky avatar jirikopecky commented on May 23, 2024

@daveaglick I have created a pull request that should address this issue: #45, could you please take a look? The solution is taken from Roslyn MSBuildWorkspace and related classes and utilizes project creation through ProjectRootElement class.

from buildalyzer.

daveaglick avatar daveaglick commented on May 23, 2024

@jirikopecky Thanks! I took a quick glance at the PR the other day and it looked good. I'll take a closer look and merge it in hopefully next week. Also have a couple other things to get in (plus a new MSBuild API) so I'll probably do a release with these changes next week too.

from buildalyzer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.