Coder Social home page Coder Social logo

Comments (7)

Phlya avatar Phlya commented on July 1, 2024

Thank you, I kept getting notifications about this but couldn't be bothered to figure it out. I updated the action to the new one that you linked, I hope it works...

from adjusttext.

JAGulin avatar JAGulin commented on July 1, 2024

Maybe I should have said that I have no experience with this, so I hoped you would know. :)

Note that your old script used secrets.PYPI_PASSWORD and new has secrets.PYPI_API_TOKEN, which I'm not sure you have configured.

5912cc8

Looking again I read "These are obsolete now and you should remove them from your GitHub repository and revoke them in your PyPI". Not sure why the github instructions didn't say so.
These other instructions looks smart, if you're going to re-do config anyway.

https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

https://docs.pypi.org/trusted-publishers/
https://docs.pypi.org/trusted-publishers/adding-a-publisher/

from adjusttext.

JAGulin avatar JAGulin commented on July 1, 2024

Anyway, I was going to suggest that you consider another release ahead of 1.0. That's an idea if you want to test the release script...

Make 0.8.1 or 0.9 release, with backported stuff?

  • documentation on pypi. ba6c70e
  • maybe some more of the new commits are bugfixes to old engine too?
  • RTD should default to "stable" 0.8 rather than the "latest" (but have both to select).
    ** Since you have tags already, this may be a matter of config in the RTD rather than any change in code?
    ** https://docs.readthedocs.io/en/stable/versions.html

Perhaps prepare fwd compatible if easy:

  • fwd compatible only_move: string-only input.
  • fwd compatible only_move: "y+" support

PS. I noticed the badge "Documentation Status" says "docs failing".
https://adjusttext.readthedocs.io/en/latest/
Docs currently say "Revision b54b855" which was the revision before this update.
Not sure why that would be related to the change, but worth to note.

from adjusttext.

Phlya avatar Phlya commented on July 1, 2024

My god, why do they have to change how things are done all the time... Thank you for the feedback and suggestions. Would you perhaps like to work on this and contribute to the package? I have a very limited bandwidth these days and not much time/energy to invest into this, so would be amazing to get someone else to join in supporting and maintaining the package,

from adjusttext.

JAGulin avatar JAGulin commented on July 1, 2024

I understand, and I'd be happy to help, although my engagement was mostly random chance and not the life-long commitment you have. :) Looks like there have been other contributers as well, so maybe possible to get a team together.

Forgive my long messages. I wanted to asses the spirit of the project before making any larger PR. I'll get back with some kind of suggestion for an "old version" branch to see what you think. I can try publishing to a dummy package too, but for the actual release and config it probably ends up in your lap anyway.

If you could have a look at this part while waiting, that would be nice. No hurry otherwise:

from adjusttext.

Phlya avatar Phlya commented on July 1, 2024

I fixed the latest docs so the build passes.

But the stable build is broken, and from what I understand, to fix it I need to make a new release with .readthedocs.yml file included in it... Not too hard, maybe I'll find some time to do it this week.

from adjusttext.

Phlya avatar Phlya commented on July 1, 2024

The stable docs are not as pretty, but looks like they are fixed!

from adjusttext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.