Coder Social home page Coder Social logo

Comments (7)

phips28 avatar phips28 commented on August 16, 2024

Its intended to look into all commit messages.

We could introduce a config flag like ciCheckInLastMessageOnly Or any better naming 😉

if you want to create a PR I can merge it

from gh-action-bump-version.

ghm-salvarado avatar ghm-salvarado commented on August 16, 2024

Similar issue here, but related to a PR that was squashed and merged:

messages: [
  'pull request title\n' +
    '\n' +
    '* squashed commit message\r\n' +
    '\r\n' +
    '* ci: version bump to v0.32.0\r\n' +
    '\r\n' +
    '* squashed commit message\r\n' +
    '\r\n' +
    '* squashed commit message\n' +
    'undefined'
]
✔  success   No action necessary!

There's only one string in the messages array, but since ci: was present in the body of a commit from an upstream merge into this branch, the workflow was skipped. Would it make sense to add a ^ to the regex to ensure only ci: in the very beginning of the message triggers a skip?

from gh-action-bump-version.

phips28 avatar phips28 commented on August 16, 2024

@ghm-salvarado if you want to create a PR I can merge it

from gh-action-bump-version.

dallen4 avatar dallen4 commented on August 16, 2024

Just curious about the status of this issue or if anyone is working on a patch? I implement this version bump in multiple branches (deployment stages) and when merging into production branch it doesn't bump out of the pre-release version because it detects the older bumps. Will work on a flag or something to implement if this isn't being worked on 🙂

from gh-action-bump-version.

phips28 avatar phips28 commented on August 16, 2024

afaik no one worked on this. So happy to merge your PR.

from gh-action-bump-version.

dallen4 avatar dallen4 commented on August 16, 2024

I took it a step further to allow for a couple settings. See #146.

from gh-action-bump-version.

phips28 avatar phips28 commented on August 16, 2024

thanks! :)

from gh-action-bump-version.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.