NullPointer when triggered by branch close about gh-action-bump-version

[phips28]

can you share your config file?

this action does not publish to npm, do you have an other action for that?

[NeonWizard]

I'm getting this same problem. Here is my configuration:

name: Bump NPM Package Version

on:
  workflow_dispatch:
  pull_request:
    branches: [ develop ]
    types: [ closed ]

jobs:
  version:
    name: Version
    if: ${{ github.event.pull_request.merged == true || github.event_name == 'workflow_dispatch' }}
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          ref: develop
          token: REDACTED

      - uses: phips28/gh-action-bump-version@master
        env:
          GITHUB_TOKEN: REDACTED
        with:
          target-branch: 'develop'
          skip-tag: true
          # only increment patch version (default)
          # regardless of commit history
          minor-wording: 'SOME UNIQUE STRING THAT WILL NEVER BE USED HOPEFULLY'
          major-wording: 'SOME UNIQUE STRING THAT WILL NEVER BE USED HOPEFULLY'
          rc-wording: 'SOME UNIQUE STRING THAT WILL NEVER BE USED HOPEFULLY'

[phips28]

Can you spot the error? maybe you can provide a fix via PR. I am currently limited in time to debug this issue :(

[NeonWizard]

Can you spot the error? maybe you can provide a fix via PR. I am currently limited in time to debug this issue :(

I'll see if I can take a peek sometime within the next week. For now, I managed to get the desired behavior with the following temporary workaround. Using on: push rather than on: pull_request lets the action work from the perspective of the branch being merged into, rather than the perspective of the branch being merged. This may give a hint as to what the issue is.

name: Bump NPM Package Version

on:
  workflow_dispatch:
  push:
    branches: [ develop ]

jobs:
  version:
    name: Version
    if: ${{ startsWith(github.event.head_commit.message, 'Merge pull request') || github.event_name == 'workflow_dispatch' }}
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          ref: develop
          token: REDACTED

      - uses: phips28/gh-action-bump-version@master
        env:
          GITHUB_TOKEN: REDACTED
        with:
          target-branch: 'develop'
          skip-tag: true
          # only increment patch version (default)
          # regardless of commit history
          minor-wording: 'SOME UNIQUE STRING THAT WILL NEVER BE USED HOPEFULLY'
          major-wording: 'SOME UNIQUE STRING THAT WILL NEVER BE USED HOPEFULLY'
          rc-wording: 'SOME UNIQUE STRING THAT WILL NEVER BE USED HOPEFULLY'

[robgutsopedra]

Hey,

Just wanted you to know I'm still experiencing this exact same issue.

I have the following:

on:
  pull_request:
    types:
      - closed

jobs:
  setup-test-build:
    name: Setup, Build, Bump_version, test, Push Docker Image to GCR
    runs-on: self-hosted
    if: github.event.pull_request.merged == true

- name: 'Automated Version Bump'
        uses: 'phips28/gh-action-bump-version@master'
        continue-on-error: false
        env:
            GITHUB_TOKEN: REDACTED
        with:
            minor-wording: 'feat,feature,minor,add,Adds,new,Debug'

The error I am getting is:

And I suspect it will always fail as long as I'm working with pull request and not with pushes. Clearly the line failing is -->

I'm guessing the parameter it should be getting on a pull request is not github_ref but base_ref, shouldn't it?