Coder Social home page Coder Social logo

Comments (6)

phips28 avatar phips28 commented on August 16, 2024

thx.

  1. thats currently not possible to customize the msg. but you can fork and create a pull request with customization option for that
  2. major: 0.9.5 => 1.0.0 (minor: 0.9.5 => 0.10.0, patch: 0.9.5 => 0.9.6)

from gh-action-bump-version.

Benwick91 avatar Benwick91 commented on August 16, 2024

Thank you for the quick answer. II meant 1.0.0 and not 7.0.0. I will see when I get time to fork and make a PR. :)

I have two more questions. I hope this is ok:

  1. I am using the action to test on push and it works without problems. Now I want to use it when pushing in master (so when the PR is merged). But the master, we work on, is protected. What will be the best way to do it? I need the value from the master.
  2. The first time I want to use it with pushing in master the version wasn't bump, and it shows the message: 'No action necessary!'
    Where does he check the commit messages? Because on push to the PR it works every time (even on the same branch)

Thank you!

from gh-action-bump-version.

phips28 avatar phips28 commented on August 16, 2024
  1. I havent tested with protected branches, but it seems that it doesnt work for GH actions: https://github.community/t5/GitHub-Actions/How-to-push-to-protected-branches-in-a-GitHub-Action/td-p/29609/page/3

  2. check the code here: https://github.com/phips28/gh-action-bump-version/blob/master/index.js
    this might be the case that you already pushed the version in your PR, then merged to master and then your commit message includes 'version bump to' https://github.com/phips28/gh-action-bump-version/blob/master/index.js#L17

from gh-action-bump-version.

Benwick91 avatar Benwick91 commented on August 16, 2024

Thank you!

  1. You seem to be right. That's a pitty. It will be very helpful in a workflow with PRs and protected master. But that's not your fault. So I will not be able to use this charming action.
    I thought it could work with:
env:
    GITHUB_TOKEN: ${{ secrets.ACCESS_TOKEN_PUSH}}

But it doesn't work.
Thank you for your time :)

from gh-action-bump-version.

Benwick91 avatar Benwick91 commented on August 16, 2024

I now make a new workflow. I created a protected branch develop and opens the master. So my PRs goes into develop. And when develop is pushed into master, the version is bumped. Not the best way but it works.

But now I think about one problem:
If one PR has a "major" and one has a "minor", and both are merged into develop and after that the whole develop is merged in master, what will be the new bumped version? We will see :D

from gh-action-bump-version.

phips28 avatar phips28 commented on August 16, 2024

the latest commit wins, thats how git works.

from gh-action-bump-version.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.