Comments (6)
thx.
- thats currently not possible to customize the msg. but you can fork and create a pull request with customization option for that
- major: 0.9.5 => 1.0.0 (minor: 0.9.5 => 0.10.0, patch: 0.9.5 => 0.9.6)
from gh-action-bump-version.
Thank you for the quick answer. II meant 1.0.0 and not 7.0.0. I will see when I get time to fork and make a PR. :)
I have two more questions. I hope this is ok:
- I am using the action to test on push and it works without problems. Now I want to use it when pushing in master (so when the PR is merged). But the master, we work on, is protected. What will be the best way to do it? I need the value from the master.
- The first time I want to use it with pushing in master the version wasn't bump, and it shows the message: 'No action necessary!'
Where does he check the commit messages? Because on push to the PR it works every time (even on the same branch)
Thank you!
from gh-action-bump-version.
-
I havent tested with protected branches, but it seems that it doesnt work for GH actions: https://github.community/t5/GitHub-Actions/How-to-push-to-protected-branches-in-a-GitHub-Action/td-p/29609/page/3
-
check the code here: https://github.com/phips28/gh-action-bump-version/blob/master/index.js
this might be the case that you already pushed the version in your PR, then merged to master and then your commit message includes 'version bump to' https://github.com/phips28/gh-action-bump-version/blob/master/index.js#L17
from gh-action-bump-version.
Thank you!
- You seem to be right. That's a pitty. It will be very helpful in a workflow with PRs and protected master. But that's not your fault. So I will not be able to use this charming action.
I thought it could work with:
env:
GITHUB_TOKEN: ${{ secrets.ACCESS_TOKEN_PUSH}}
But it doesn't work.
Thank you for your time :)
from gh-action-bump-version.
I now make a new workflow. I created a protected branch develop and opens the master. So my PRs goes into develop. And when develop is pushed into master, the version is bumped. Not the best way but it works.
But now I think about one problem:
If one PR has a "major" and one has a "minor", and both are merged into develop and after that the whole develop is merged in master, what will be the new bumped version? We will see :D
from gh-action-bump-version.
the latest commit wins, thats how git works.
from gh-action-bump-version.
Related Issues (20)
- Issue if the main branch is locked HOT 1
- Deployment event does not take in the target branch attribute
- v10? HOT 1
- Release not getting latest versions? HOT 2
- use >> $GITHUB_OUTPUT when runner is version 2.297.0 or greater
- Support hotfixes ("post-releases")
- Bumps minor or major instead of patch HOT 4
- Please support to change the package.json filename HOT 2
- Support for Selectively Adding Only package.json in git add HOT 1
- Trigger new workflow run on push HOT 1
- Add ability to provide value for parsing instead of commit messages HOT 1
- chore: bump node version HOT 1
- Error: Invalid format '├── https://github.com/sponsors/broofa' HOT 19
- Need to modify filename package.json to another filename. Is it possible? HOT 1
- Add option to add --no-verify to git commit HOT 3
- Anything that can be done to improve performance? HOT 4
- Issues with branch being up to date in a monorepo HOT 5
- Any tags pushed from the Bumped version commit not triggering any github workflows. HOT 2
- Output paring breaks due to unexpected outputs - add silent flag HOT 5
- [request] Document `newTag` output and how to consume it HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gh-action-bump-version.