Coder Social home page Coder Social logo

Comments (4)

philss avatar philss commented on May 26, 2024 1

@WLSF I think I can't assign directly to you. But feel free to work on this :)

from floki.

philss avatar philss commented on May 26, 2024 1

@philss yeah, I was wrong. It should be html_node() | html_tree() as @hattmarris suggested.
And yeah, you could replace that part by html_node() 👍. Thanks for verifying it :)

from floki.

philss avatar philss commented on May 26, 2024

@hattmarris I think you are right. The return type should be {html_tree(), traverse_acc} as it was before. I don't know why I didn't catch that, but I think the correct is the previous version.

Would you mind to send a pull request?

from floki.

WLSF avatar WLSF commented on May 26, 2024

@philss couple of things that I've noticed:

The function traverse_and_update/3 actually accepts a string as arg/response, as you can see on this test, is there a reason for it?

If thats by design then I guess that there are other aspects of this spec that might not be right, because right now its expecting the first arg and the response to be [html_node()], but as the test shows, its working with a simple string.

Assuming everything is ok with the STRING thing, I guess we could also replace this part by: html_node() since it already contains everything @type html_node :: html_tag() | html_comment() | html_doctype() | html_declaration() | html_text()

from floki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.