File and Line number is reported as coming from bunyan instead of location of log. about browser-bunyan

[RanzQ]

@jduprey This is a limitation with the default ConsoleFormattedStream. Browser outputs the line where console.log is called, but the real info is in rec.src. You can create your own stream (check what ConsoleFormattedStream does). Since this is not the full node-bunyan, some things might not work as expected. :)

[RanzQ]

Actually after trying this myself, the rec.src is empty, due to this line being commented:

https://github.com/philmander/browser-bunyan/blob/master/lib/bunyan.js#L98

Anyway, how I modified the stream:

 function getSourceLine (rec) {
      console.log('getting src', JSON.stringify(rec.src))
      if (!rec.src) return ''
      else return ' [' + rec.src.file + ':' + rec.src.line + ']'
    }

    console.log('[%s:%s:%s:%s]%s %c%s%c: %s: %c%s',
        padZeros(rec.time.getHours(), 2), padZeros(rec.time.getMinutes(), 2),
        padZeros(rec.time.getSeconds(), 2), padZeros(rec.time.getMilliseconds(), 4),
        getSourceLine(rec),
        levelCss, levelName,
        defaultCss, loggerName,
        msgCss, rec.msg);
    if(rec.err && rec.err.stack) {
        console.log('%c%s,', levelCss, rec.err.stack);
    }

[philmander]

Thankyou @RanzQ

I'm looking into this a bit more.

[philmander]

@RanzQ I tried to replicate your fix, but I get an error:

browser-bunyan.js:99 Uncaught TypeError: Object.defineProperty called on non-object

This is also after setting src:true in the logger options. Does it definitely work for you?

This is probably why I commented out that line originally. I'm thinking I might need to do something along these lines:

var err = new Error();
var stack = err.stack;
rec.src = getThirdCallerFromStack(stack) // I think this part would require some x-browser stack trace parsing code

[RanzQ]

@philmander Yeah sorry, forgot to update the answer. After uncommenting the line I ended up with the same error. My "fix" was just for the string format.

I can try with original bunyan if it works with webpack.

[RanzQ]

So, wasn't able to make it work with the node-bunyan either, I just get an empty object from getCaller3Info.

I've found it best to debug with console.log and create the final logger with browser-bunyan. When using named child loggers you don't necessarily need the line number. :)

[philmander]

I've added line number support on this branch. This contains a working build

I've tested in latest Chrome and Firefox. I will do some testing/add-support in other browsers, probably IE and Safari and then merge and then release

[philmander]

I've released a fix working across major browsers @ 0.3.0

[jduprey]

Thank you!