Comments (7)
Yeah, i agree that the deps/discount files is messy. I'm no expert with CMake but i'll see what i can do about it :)
The config.vala appears on the rest of the elementary projects though, so maybe that works as intended (?)
from notes-up.
I think this has been solved via the recent merge of the .gitignore list.
Simply:
mkdir build && cd build
cmake ..
make
from notes-up.
Mmm not really, It's still adding files on deps/discount. The expected behaviour is that everything gets added inside of build
. But it was a good middle step :)
from notes-up.
I am working on configuring CMake to download discount directly from the source. The version of discount being downloaded will not change. So version 2.2.0 will be downloaded. Once the download finished, CMake will then compile discount from there.
Right now I have it working on my machine but am going to test a build on Loki VM after work.
from notes-up.
@Philip-Scott Do you think its wise to have CMake download discount from Github or should CMake use git-submodules? I am conflicted between both options. I am not too familiar with git-submodules but I can learn more about them.
from notes-up.
If i understand submodules correctly, i think using them might be safer since i could at least make sure that the release is working properly with the module i'm targeting instead of having it download automatically (and potentially breaking)
from notes-up.
OK. I am going to explore using that instead of downloading. I was having second thoughts about downloading the library as there was no sha256 checksum provided with the download. People would have to trust that the library was not modified.
from notes-up.
Related Issues (20)
- make: error
- elementary Odin SDK port
- [Feature Request] Add ability to paste image from clipboard
- Tables look weird in dark mode
- Package as Flatpak for elementary OS 6 HOT 1
- Feature Request: Password protected notes HOT 1
- Notes-Up not included in Curated apps in Elementary AppCenter HOT 1
- Is this app dead? HOT 1
- Failed to build com.github.philip-scott.notes-up
- Screenshots are outdated
- App ID doesn't match
- 2.0.3 desktop file validation test fail HOT 2
- Screenshots don't use default settings HOT 1
- How do I change the global style? HOT 1
- Ability to choose location of NotesUp.db
- Line breaks in 'code' formatting
- Maximization settings are not remembered
- Slow scrolling in view mode
- won't start HOT 7
- Adding note segfaults app
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notes-up.