Coder Social home page Coder Social logo

Comments (11)

penn5 avatar penn5 commented on June 16, 2024

Maybe install magisk manager and use the installed su to convert to magisk. Afaik magisk can do this.

from treble_experimentations.

kaiomatico avatar kaiomatico commented on June 16, 2024

Thank you for the great idea, but as soon as I grant Magisk Manager the root permissions the app crashes and android asks me if I want to re-open the app.

from treble_experimentations.

kaiomatico avatar kaiomatico commented on June 16, 2024

Closed because according to this post GSI's will never support SafetyNet :(
https://forum.xda-developers.com/showpost.php?p=76424596&postcount=1804

from treble_experimentations.

weirdal3333 avatar weirdal3333 commented on June 16, 2024

UH, my phone completely passes safetynet with the vanilla GSI and magisk...

Please make a build release with gapps, but no su for both 8.1 and 9 versions.

from treble_experimentations.

penn5 avatar penn5 commented on June 16, 2024

When you pay for a faster build host he can. Until then, no go.
I'd suggest using a gapps addon

from treble_experimentations.

weirdal3333 avatar weirdal3333 commented on June 16, 2024

I'm building it myself using the dakkar script. If I use the original boot.img before I flash the GSI without unlocking the bootloader, it passes safetynet. My case might be a special case because spflashtool works with and without unlocking via fastboot. I have a DoogeeS70 MT6367v (helio p23).

Edit: I then use magisk to build the boot.img after it boots and I set up everything (rip my data lol), and flash (locked bootloader) with spflashtool.

from treble_experimentations.

penn5 avatar penn5 commented on June 16, 2024

Yes, that's a special case. Your phone hasn't got a tripped secboot flag so you don't have to unlock it. Most phones need bootloader unlock to boot a gsi. To pass with an unlocked bl, you'd have to spoof it as locked to Android.

from treble_experimentations.

weirdal3333 avatar weirdal3333 commented on June 16, 2024

NICE! So if I build a GSI without su, and use Magisk, it should work? I'm giddily happy now. I hope that there comes a time where GSIs can get OTA updates so I don't have to build the entire image each time ^_^

Edit: Unrelated, but I'm using PdaNet+ on another android as my internet connection, ya think T-Mobile might get mad about my terabyte of usage?

from treble_experimentations.

weirdal3333 avatar weirdal3333 commented on June 16, 2024

Hey, just a thought, but why is @phhusson including su by default? Magisk is probably a better option because it's optional.
It might reduce the build-time and resources if he removed it from all of the builds, and more devices would have a chance of passing safetynet. Is he purposely trying to fail safetynet?
After a bit of testing and research, I've found that you can relock the bootloader after flashing on lots of MTK devices, and Magisk is compatible with the ones I tested.

from treble_experimentations.

phhusson avatar phhusson commented on June 16, 2024

from treble_experimentations.

weirdal3333 avatar weirdal3333 commented on June 16, 2024

That makes sense.

In any case, installing the Magisk zip actually removes any pre-existing su, and allows the device to pass the important half of safetynet. If I really wanted to, I could then uninstall Magisk and that would remove root from the device.

I've learned a whole bunch since my last comment, and I can see where you're coming from. Since safetynet actually tries to find a file called 'su', maybe you could include a script that you can run from recovery to remove root? I don't know if it's one file or not, but if it is maybe make a button that you have to tap 10 times at the bottom of developer options that removes root and reboots if the user really wants to do that 😁

Side note: setting up a device for older non-tech people needs root (I have to make certain apps persistent like TeamViewer for Android, the launcher, a WiFi password, and DNS settings, among other things because of accidental factory resets), but I don't want them accidentally deleting everything in /system somehow. It's happened before. I don't know how.

from treble_experimentations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.