[NFR] ORM: add the ability to return a custom Phalcon\Mvc\Model\Row class instance about phalcon

[Jurigag]

Well i really like this idea, we could even for example create like Entity class without any extends or something which would have all necessary methods, and extend it both in our model class and row class, so we could still have all needed methods(though this could be achieved already therotically with magic __call.

[richmilns]

I've had a go at adding this functionality - it's my first time using Zephir but I was able to test this and it seems to be working as outlined above.

I added get/set methods for the Resultset Row Class.

[richmilns]

I just saw the announcement about 3.4.2 being the last release for 3.x. My code above was based on the 3.4.x branch of Phalcon, so I guess it might be in the wrong place! Please advise if this needs to be refactored on the 4.0.x branch instead, and if you'd like this submitted as a pull request?

[Jurigag]

I think we should consider this more to have better compability with php 7.2 features, what i mean:

interface Xyz
{
    public function getName();
}

class RowXyz extends Phalcon\Mvc\Mode\Row implements Xyz
{
    public $name;

    public function getName()
    {
        return $this->name;
    }
}

class ModelXyz extends Phalcon\Mvc\Model implements Xyz
{
    protected $name;

    public function getName()
    {
        return $this->name;
    }
}

And then somewhere we could have code like:

class XyzRepository
{
    public function findByParams(array $params) : ?Xyz
    {
        // we create somewhere $arrayParams which can have or not columns property
        return ModelXyz::findFirst($arrayParams);
    }
}

Also i would even vote for adding posibility that it doesn't needs to extend Row object, it's already simple object just having some additional methods, maybe just implementing some interface could be enough.

[richmilns]

I was hoping to re-open this if that's OK with everyone 👍

[niden]

It's open. I removed the stale tag (bot)