Comments (6)
@gdfast Apologies for the delayed response. TANK currently doesn't include a CMakeFile in the distribution, but it should be easy to create one.
from tank.
@markpapadakis no worries about the delay. And yeah, I don't think it will be difficult. I was just trying to see if you opposed it. One of my colleagues or I may put up a pull request.
from tank.
@gdfast that'd be fantastic. Thank you :)
from tank.
@markpapadakis, I've been working on getting a PR up with the CMake and SPEC files we've used for distributing TANK. But I'm hitting a snag I'd like your input on.
As context, we've build an RPM that can be installed on a system and provides the tank
and tank-cli
executables along with a tank-client.so
. Then there's a -devel
RPM that provides all of the headers necessary for building code that uses the client.
My issue is with the headers. Your Makefile has logic that checks if the build is being run on your dev system. If that is the case, you're assuming that the switch
library is installed. Otherwise, you use the LEAN_SWITCH
flag. However, throughout the code, many switch headers are included through absolute includes which fail if either 1) switch isn't installed on the system and 2) all of the switch directories aren't added to the global include path (which doesn't seem ideal).
To work with lean switch, I've needed to alter many of the switch includes to be relative rather than absolute which removes the need to add to the system include path (e.g. #include "Swtich/date.h"
rather than #include <date.h>
). Of course, this will make so lean switch is always included even if switch is installed on the system.
So I'm wondering if you have an approach that has avoided this issue or suggestions about how I should proceed. I do have a couple potential solutions that I think are pretty far from ideal. But I wanted to get the conversation started.
from tank.
@gregschrock Apologies for not replying sooner. Been busy and I missed this issue.
I suggest you wait for a little while longer for the new client, CLI tool, and TANK service branch to appear on GH. The client has been written from scratch and those and other issues you have raised have been addressed. Thanks !
from tank.
Thanks @markpapadakis! Sounds good. I look forward to seeing the changes.
from tank.
Related Issues (20)
- Add namespacing HOT 5
- Implement timers scheduler using EBTs HOT 1
- GC inactive connections HOT 1
- Optimizations for consumer/tailing semantics HOT 2
- Simultaneous Consumes Confuse Response Messages HOT 9
- Corrupt Files Produce Core Dumps HOT 4
- Problem with Client when receiving more than one consume message HOT 4
- Crashes when system time is before Jan 05 2016 08:27:06 HOT 1
- TANK client: batch produced messages for efficiency
- Topic creation improvements HOT 1
- Adopt C++2a coroutines and io_uring
- Compactions improvements
- Temporary topics support
- New API: List Topics
- try_tx() improvements HOT 1
- Performance: Ideas from Phaistos's Microservice reactor core
- Add 'list_topics' functionality to the tank-cli HOT 1
- Inspiration: "Monitoring Kafka performance metrics"
- Inspiration: Kowl
- Defined macro names collide because they're very common
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tank.