HTTPStream.app_send is missing http.disconnect handling ? about hypercorn

[synodriver]

Hi. According to the spec, http.disconnect is an asgi receive event instead of send event, so you can not close the http connection in that way. Return 500 error would be ok.

[touilleMan]

@synodriver Ho you're right ! I read the spec a bit too fast ^^

It looks like an omission to me, especially given the websocket stream has code for handling it corresponding websocket.close

So websocket.disconnect is also an event send to the application, hence wasn't hypercorn supposed to have raise an hypercorn.utils.UnexpectedMessageError when my application sent a websocket.disconnect to the server ?

[synodriver]

You can send websocket.close which is listed in asgi spec.

Close - send event
Sent by the application to tell the server to close the connection.

If this is sent before the socket is accepted, the server must close the connection with a HTTP 403 error code (Forbidden), and not complete the WebSocket handshake; this may present on some browsers as a different WebSocket error code (such as 1006, Abnormal Closure).

If this is sent after the socket is accepted, the server must close the socket with the close code passed in the message (or 1000 if none is specified).

type (Unicode string) – "websocket.close".
code (int) – The WebSocket close code, as per the WebSocket spec. Optional; if missing defaults to 1000.
reason (Unicode string) – A reason given for the closure, can be any string. Optional; if missing or None default is empty string.

[synodriver]

So websocket.disconnect is also an event send to the application, hence wasn't hypercorn supposed to have raise an hypercorn.utils.UnexpectedMessageError when my application sent a websocket.disconnect to the server ?

Actually hypercorn did it here

[touilleMan]

thanks a lot @synodriver 😃 🎉

so it's websocket.close that is the event the application send, and websocket.disconnect (and http.disconnect) that are send to the application !