Coder Social home page Coder Social logo

Send multi-frame messages? about hypercorn HOT 6 CLOSED

pgjones avatar pgjones commented on June 20, 2024
Send multi-frame messages?

from hypercorn.

Comments (6)

pgjones avatar pgjones commented on June 20, 2024

The ability to specify the framing is not present in the ASGI specification. I think you could make an argument that it should be an ASGI extension. I've opened this issue to get views.

from hypercorn.

pgjones avatar pgjones commented on June 20, 2024

Could you comment on the ASGI ref issue?

from hypercorn.

jonozzz avatar jonozzz commented on June 20, 2024

Why change the ASGI spec? message.bytes can be an iterable of text or bytes, and in that case it should iterate through it and send BytesMessage(..., message_finished=False) similar to what the websockets lib did here.

from hypercorn.

pgjones avatar pgjones commented on June 20, 2024

Making the text or bytes an iterable would break one of the ASGI spec assumptions (that each message is complete and immutable). Whilst I could do this, the purpose of Hypercorn is to be an ASGI server, so I don't think it would be the right thing to do. I think the only option is an ASGI extension that allows for this - which would require a motivating use case.

from hypercorn.

jonozzz avatar jonozzz commented on June 20, 2024

If that's the case then there should be a note in the documentation disclosing that hypercorn/quart doesn't fully implement the websockets protocol (rfc6455), in particular the continuation frames, so that whoever wants to use these libs is aware of the limitation.

The most obvious use case is server sending a message of unknown length (e.g. streams like compressed files, live media streaming, etc.) or buffered large file transfers. In my case I was only testing the protocol and was hoping that I'd get the same functionality as with the websockets library.

from hypercorn.

pgjones avatar pgjones commented on June 20, 2024

I think the documentation is sufficient, in that Hypercorn claims to be an ASGI compliant server rather than a complete WebSocket server.

I think there is a case for this being an ASGI extension though, it does require convincing others in the ASGI issue though.

from hypercorn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.