Bad search_path in extension script about pgaudit

[cbandy]

Is this true? Can you please show an example of the quotes having an effect?

[rdunklau]

Not on pgaudit itself, as mentioned it doesn't matter in practice here, but it gives a false sense of doing the right thing.

See this example:

create schema if not exists "public, pg_catalog, pg_temp";

create or replace function public.f1() returns timestamptz as $$
SELECT now();
$$ language sql;

create or replace function "public, pg_catalog, pg_temp".f1() returns timestamptz as $$
BEGIN
    RETURN '1900-01-01'::timestamptz;
END
$$ language plpgsql;

create or replace function test_function() returns timestamptz AS $$
    SELECT f1();
$$ language sql;

create or replace function test_function2() returns timestamptz AS $$
    SELECT f1();
$$ language sql
SET search_path = public, pg_catalog, pg_temp;

create or replace function test_function3() returns timestamptz AS $$
    SELECT f1();
$$ language sql
SET search_path = 'public, pg_catalog, pg_temp';

Now running that:

ro=# SELECT 
test_function() as default_search_path, 
test_function2() as correct_search_path, 
test_function3() as quoted_search_path;
     default_search_path      |     correct_search_path      |      quoted_search_path      
------------------------------+------------------------------+------------------------------
 2023-10-27 08:24:40.94749+02 | 2023-10-27 08:24:40.94749+02 | 1900-01-01 00:00:00+00:09:21
(1 ligne)