Comments (3)
It unfortunately does get increasingly awkward to work around. While I think more flexibility is nice, I don't think rust really has the features we need to implement this properly at the moment (not to mention the back-compact difficulties) so I'm going to suggest we hold off making any changes, but I do appreciate the discussion.
from strum.
I think this triggers a warning/error if you do this? Are you suggesting something like this (playground link)?
Unlike EnumDiscriminants, IntoEnumIterator
implements a trait on your enum type which means the iterator type needs to be at least as visible as the Enum type itself.
from strum.
Okay yeah, I do get an error when I'm missing the same visibility as the enum type.
I tried to experiment with having IntoEnumIterator::iter
return an opaque type (e.g. fn iter() -> impl Iterator<Item = Enum>
) to further hide the generated EnumIter but that's not currently possible in trait definitions.
I guess we can technically force privacy and get rid of the error by redeclaring an entirely new trait within the module (playground link), but this starts becoming an unfortunate workaround
from strum.
Related Issues (20)
- derive(FromRepr) broken in 0.25.0 HOT 13
- Unwrap methods HOT 6
- strum(serialize_all vs serde(rename_all HOT 1
- rustfmt::skip is broken by derive(FromRepr) HOT 1
- Maybe EnumCount should respect `#[repr(...)]` like FromRepr HOT 2
- EnumDiscriminants should inherit the repr of the enum they are derived from HOT 1
- `could not find fmt in core` when upgrading to 0.25 HOT 1
- Proposal: Exclude macro for EnumIter macro
- IntoStaticStr but from immutable reference to an enum From<&MyEnum> HOT 7
- `EnumString` match with non-default variables HOT 1
- Feature request: A function to convert to integer by variant HOT 1
- EnumIter does not work for enums named 'Option'
- [Feature] Macro to Implement PartialEq<str> HOT 1
- strum::Display doesn't work with non-unit non-string variants
- `EnumString` should derive `From<&str>` instead of `TryFrom<&str>` when `#[strum(default)]` is present HOT 1
- to_string and serialize when used together causes unreachable code HOT 2
- `get_bool` and `get_int` in `EnumProperty` are undocumented and always return None
- AsRef<str> and default variants
- EnumDiscriminants: can't infer type HOT 3
- Getting the discriminant from an enum variant HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strum.