Coder Social home page Coder Social logo

Visibility for EnumIter about strum HOT 3 OPEN

mdaverde avatar mdaverde commented on June 14, 2024
Visibility for EnumIter

from strum.

Comments (3)

Peternator7 avatar Peternator7 commented on June 14, 2024 1

It unfortunately does get increasingly awkward to work around. While I think more flexibility is nice, I don't think rust really has the features we need to implement this properly at the moment (not to mention the back-compact difficulties) so I'm going to suggest we hold off making any changes, but I do appreciate the discussion.

from strum.

Peternator7 avatar Peternator7 commented on June 14, 2024

I think this triggers a warning/error if you do this? Are you suggesting something like this (playground link)?

Unlike EnumDiscriminants, IntoEnumIterator implements a trait on your enum type which means the iterator type needs to be at least as visible as the Enum type itself.

from strum.

mdaverde avatar mdaverde commented on June 14, 2024

Okay yeah, I do get an error when I'm missing the same visibility as the enum type.

I tried to experiment with having IntoEnumIterator::iter return an opaque type (e.g. fn iter() -> impl Iterator<Item = Enum>) to further hide the generated EnumIter but that's not currently possible in trait definitions.

I guess we can technically force privacy and get rid of the error by redeclaring an entirely new trait within the module (playground link), but this starts becoming an unfortunate workaround

from strum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.