Form data resets when hitting enter while selecting Text, Radio widget when only one effect present about asciimatics

[peterbrittain]

Thanks for your support!

I think I see the issue here... The widgets you're hitting this on don't actually handle the input and so it bubbles all the way up to the unhandled input function, which will move on to the next scene on Enter. This resets the form for this demo.

I'll have a think about the proper fix, but in the meantime, you can just specify your own function (which could ignore all events) by passing it to play() as the unhandled_input parameter.

[brycepg]

passing an empty function to screen.play(...,unhandled_input=lambda x: None) Did fix it, thanks.

If I subclassed Text or RadioButtons, and extended the process_event method to do something with key codes [10, 13] (and not return the event in that case), then the events would not bubble up from Widget to Effect to Scene into the Screen, correct?

[peterbrittain]

Great! I'm much happier with the empty function workaround than a hidden Effect.

Swallowing those events by subclassing the widgets (as per your suggestion) would also work. I'm not sure I want to use that for the final fix as it may prevent some future feature. To be honest, I don't know what that might be right now, but it feels I'm restricting input "just in case" rather than because the widget depends on it.

In the spirit of making asciimatics do what you would naturally want, I think I'd rather that it just defaults to an empty function (for unhandled input) if any Frames are present in the Scenes to be played.

[peterbrittain]

OK - I've had a go at fixing it with 2b4c9e6. That solves all the issues for me.

Please let me know if that fixes it for you too, then I'll close the issue.

[brycepg]

That's an interesting way fix it. Yes the current master commit no longer has this issue, thanks.

[peterbrittain]

Great! I prefer to get asciimatics to give sensible defaults so that the user of the API doesn't have to get involved with the complexity if they don't want to... It sometimes means I have to jump through a few hoops.

In this case, I would have has a circular dependency between the screen.py and widgets.py if I had just started looking an object types, so thought it best to expose the decision through a formal API.