RRule object is not initialized with dtstart about ical.js

[LionelMartin]

Failing test case here : https://github.com/LionelMartin/ical.js/commit/a32a747900dddba64d65f46e8591521de62bfbaf#test

[bastinat0r]

Same problem here.
(LionelMartin: thanks for the hack)

[peterbraden]

I believe this was fixed by #48 - can you run your test and confirm?

I'd love to add the test to the suite if this solves it.

[Angus71]

I also stumbled across this one and made some changes, which work for me. From my point of view this is still a hack, as I don't like the changes I've made in ical.js/addTZ(..). Maybe somebody has a better idea, how to implement it.
The main problem I found, was that you can't depend on the position of the "DTSTART" if this comes before the "RRULE" then the #48 might work, but I had problems with it as the fix will not update the already created a "BYMOUNTH" and "BYDATE" in the rrule cache.
On the other hand if "DTSTART" follows RRULE #48 might never work, so the same fix done in "RRULE" handling needs also be done when DTSTART is parsed.
As said previously I consider this quite a hack, but as this problem is around nearly a year I though sharing might be helpful. If required/wanted I can created a pull request, but the code might need some additional testing.

[risacher]

I ran across this problem also. The fix for #48 does not completely fix #21 - in that ev.rrule.between() does not seem to work properly... even though rrule.options.dtstart seems to be set, it's not being honored. (Perhaps ev.rrule.origOptions is being used instead?)

I independently developed my own fix, which is shown below. This code fixes the problems that I was experiencing, but potentially suffers the same deficiency that @Angus71 noted, namely that if "DTSTART" comes after the "RRULE", then it should not work. (and if RRULE includes a DTSTART field it will be overwritten, although this is easily fixed.)

ical.objectHandlers['RRULE'] = function(val, params, curr, stack, line){        
  var rule = line.replace("RRULE:", "");                                        
  rule += ";DTSTART="+curr.start.toISOString().replace(/[-:]/g,'');             
  rule = rule.replace(/\.[0-9]{3}/, "");                                        
  curr['rrule'] = rrule.fromString(rule);                                       
  return curr                                                                   
}             

[risacher]

The DTSTART/RRULE sequencing issue noted by @Angus71 (and later me) should probably be fixed by moving the code that patches up the RRULE with a default start date into the objectHandler for 'END'. I'll try this tonight.

[ericlathrop]

@risacher Any luck fixing this?