Discussion: new I2C sensor SHT30 about smooth

[PerMalmberg]

Disclaimer: I've not read the whole data sheet so I might be missing something.

Based on table 9 in the spec it seems to me combining the existing write and read functions should work. My intention with these methods was that they do the ground work to follow the i2c spec and combining them yields the desired write/read sequences needed for the specific device assuming the expect_ack, use_restart_signal and end_with_nack are correctly set.

The 16-bit register you refer to must the the command bytes, They are not an register address so they can we written with the write command.

I don't think I've used clock-stretching, but if it is handled by the underlying driver then it might work as-is. It is also an optional mode of the device so it is not a must to use.

Lastly, the delay between sending commands to the device can be easily handled by checking against a timestamp of the last command and waiting until 1ms has passed.

[enelson1001]

I plan on submitting a pull request for this sensor today or tomorrow. The PR will include a new function added to I2CMasterDevice called

read_block(uint8_t address,  core::util::FixedBufferBase<uint8_t>& data,  bool end_with_nack)

This new function does not include the i2c_master_write as the current read does but only implements the i2c_read.

This new function allowed me to read data from the SHT30.

You can close this discussion since we can discuss further in the PR. If you don't like the name of the function then the name can be changed during the PR process.