varying path separators in paths in carton.lock, problem or not? about carton

[miyagawa]

I think the intention here is that a) file paths should most always
encoded using the forward slashes, independent of the actual file
system b) portability for windows is not a top priority.

Sent from my iPad

On Oct 19, 2011, at 12:59 AM, Christian Walde
[email protected]
wrote:

I develop on windows and deploy on linux, which means that when i change the carton.lock file, the whole thing gets changed a lot, because doing so on windows results in \ separators, while on linux they all get replaced with / separators.

I'm not sure whether it's worth digging into and what the intended behavior is. Thoughts?

Reply to this email directly or view it on GitHub:
#23

[wchristian]

Perfect. For what it's worth: The backward slashes do almost nothing towards windows compatibility, since very few tools i encounter are unable to use them. In fact, more often than not using backward slashes breaks things even on windows. As such i'm perfectly happy to enforce forward slashes everywhere.

You'll be getting a patch for that.

[miyagawa]

Yeah, perl tools are most of the time able to use forward slashes. The only exceptions are when we need to shell out to the commands, like specifying the path for cmd.exe via system.

Also for the note of portability:

While I don't have a big priority on making the Carton code portable as possible, it'd be always good to ensure it works on foreign platforms such as Win32, so long as the code doesn't get a whole mess or too complicated to maintain.

For the future note, your use case of building vs deploying on different platforms is a separate issue that we need to address in the future. For example, some of the modules would require separate Win32:: modules as a dependency on Windows platform. We can expect the same thing for perl versions, such as building the dep list on 5.14 and deploy on 5.8 - because 5.14 has more core modules than on 5.8, chances are you'll miss some of the modules in the carton.lock file.

[wchristian]

It's honestly not only perl tools. Whenever i do stuff on the command line i just habitually use / and it's not been an issue for the past few years for me. :)

As for the portability note: I figured that was already adressed by the lib path you use. Sounds like a massive ball of wax to get into. :/

But i guess once i run into actual issues with that, since my dev perl and os are different from my deploy perl and os, i'll be making some suggestions as to how to deal with that.

---

As for the backslash issue:

I tracked it down and the problem is caused by

• loading the install.json ( https://github.com/miyagawa/carton/blob/master/lib/Carton.pm#L319 )
• created by cpanm ( https://github.com/miyagawa/cpanminus/blob/master/lib/App/cpanminus/script.pm#L1422 )
• which in turn takes the data from Module::Metadata ( https://github.com/dagolden/Module-Metadata/blob/master/lib/Module/Metadata.pm#L183 ).

That makes it three possible places to fix and i have no idea which one would be appropiate. Thoughts?