Coder Social home page Coder Social logo

Comments (7)

pepegar avatar pepegar commented on May 28, 2024

Hey @ipsq ! I've been thinking about this for some time too, but haven't had time to do it so far.

Do you want to champion it? contributions are open :)

I think the refactor would be simple, just creating a new module hammock-apache-http (or something like that) and remove that part from the core.

from hammock.

mhriemers avatar mhriemers commented on May 28, 2024

Sure, will look at it this afternoon! What do you want to do with the versioning? Since this would be a breaking change for some.

from hammock.

pepegar avatar pepegar commented on May 28, 2024

awesome! Yeah, I think we should release a new minor after this change (0.9.0), since we're still in 0 as major

from hammock.

mhriemers avatar mhriemers commented on May 28, 2024

Maybe the default JS implementation should also be moved to its own submodule. Let me know what you guys think. I can imagine some scenarios where people want to use the node request api directly without a polyfill or something like that.

from hammock.

pepegar avatar pepegar commented on May 28, 2024

I think it's better to provide one by default in that case, because it doesn't add any other dependency and is the only one available in that platform. What do you think?

from hammock.

mhriemers avatar mhriemers commented on May 28, 2024

Yeah, that's fair I guess. Was just something that popped in my mind whilst I was refactoring.

from hammock.

pepegar avatar pepegar commented on May 28, 2024

closed by #156

Thanks @ipsq !

BTW, https://oss.sonatype.org/content/repositories/snapshots/com/pepegar/hammock-core_2.12/0.8.7+52-af7aee56-SNAPSHOT/ has been published (notice that it's a snapshot). If you want you can test-drive it and if it works for you I will release a 0.9.0!

from hammock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.