Comments (7)
Hey @ipsq ! I've been thinking about this for some time too, but haven't had time to do it so far.
Do you want to champion it? contributions are open :)
I think the refactor would be simple, just creating a new module hammock-apache-http
(or something like that) and remove that part from the core.
from hammock.
Sure, will look at it this afternoon! What do you want to do with the versioning? Since this would be a breaking change for some.
from hammock.
awesome! Yeah, I think we should release a new minor after this change (0.9.0
), since we're still in 0
as major
from hammock.
Maybe the default JS implementation should also be moved to its own submodule. Let me know what you guys think. I can imagine some scenarios where people want to use the node request api directly without a polyfill or something like that.
from hammock.
I think it's better to provide one by default in that case, because it doesn't add any other dependency and is the only one available in that platform. What do you think?
from hammock.
Yeah, that's fair I guess. Was just something that popped in my mind whilst I was refactoring.
from hammock.
closed by #156
Thanks @ipsq !
BTW, https://oss.sonatype.org/content/repositories/snapshots/com/pepegar/hammock-core_2.12/0.8.7+52-af7aee56-SNAPSHOT/ has been published (notice that it's a snapshot). If you want you can test-drive it and if it works for you I will release a 0.9.0!
from hammock.
Related Issues (20)
- NullPointerException on NoContent (204) response HOT 4
- Use cats-effect bracket HOT 5
- Reduce allocation overhead by removing Kleisli layer HOT 2
- Support multipart requests HOT 7
- Add functionality for checking status codes of a response HOT 1
- Make Uri parser more restrictive HOT 4
- Runtime exceptions with Apache HTTP backend HOT 3
- BasicAuth renders wrong header name HOT 1
- Documentation Request: How to consume response and headers in one request. HOT 2
- content type is wrong HOT 1
- Make interptrans not require `F` to be a `Sync` HOT 1
- convert interpreters to methods of objects HOT 1
- WebSocket support HOT 2
- Scala 2.13 support HOT 6
- Hammock.constructHeaders does not format cookies correctly. HOT 2
- x-www-form-urlencoded content-type support HOT 1
- Doesn't load with sbt
- drop scalajs support HOT 2
- readme: "It has good documentation." links to a "404 Page not found"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hammock.