Coder Social home page Coder Social logo

Comments (6)

niwinz avatar niwinz commented on May 22, 2024

Are you sure? I have checked it right now and it works as expected.

When you clicks to "accept" a new version is created on top of the rest of history entries with the state of the desired version. No history entry is deleted or discarded on this operation.

from penpot.

studiospring avatar studiospring commented on May 22, 2024

I see. This prevents forking and version control messiness. However, I would expect selecting and accepting a version number would change the current version number. Is it possible and do you think more intuitive to change the version number of the "current" version to the version number that I selected?

From a UX perspective, it would be nice to have a slider going down the history, so that I can see the changes as a smooth animation and find the version I want faster, instead of click, click click. :D

from penpot.

elhombretecla avatar elhombretecla commented on May 22, 2024

We already think about add a slider for the version control. But now it has a lower priority :)

from penpot.

niwinz avatar niwinz commented on May 22, 2024

@studiospring it is imposible with current approach set a version number to the one that you have selected. This is because the version is a strictly incrementing atomic number that is increases with each persistence operation. So the fact of selecting a previous version and accepting it, it will perform a new save operation that will imply that the latest version with the selected change will have a new version number.

On the other hand, image if we can make this change, and do that you are proposing! This will make a lot of mess with version numbers because version numbers will repeat, because you will be able to revert to the same version multiple times in the page life. This is not a desired behavior.

In summary, that I intend to say here that this is more complex that it seems at simple view. And need more thought on it before any change.

from penpot.

studiospring avatar studiospring commented on May 22, 2024

Thanks! Got it. It sounds like something to revisit at a later date.

from penpot.

niwinz avatar niwinz commented on May 22, 2024

In any case, many thanks for open this kind of discussions, they are very positive and allows revisit some parts of the application.

from penpot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.